From: David Miller <davem@davemloft.net>
To: hau@realtek.com
Cc: netdev@vger.kernel.org, nic_swsd@realtek.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 0/3] r8169:issues fix.
Date: Tue, 01 Mar 2016 15:24:53 -0500 (EST) [thread overview]
Message-ID: <20160301.152453.1743613743070525198.davem@davemloft.net> (raw)
In-Reply-To: <1456476046-5436-1-git-send-email-hau@realtek.com>
From: Chunhao Lin <hau@realtek.com>
Date: Fri, 26 Feb 2016 16:40:43 +0800
> This series of patches fix 3 issues that are listed below.
>
> Chunhao Lin (3):
> r8169:fix nic sometimes doesn't work after changing the mac address.
> r8169:eliminate error message in using ethtool -S when nic is down.
> r8169: Enable RX_MULTI_EN for RTL_GIGA_MAC_VER_41~48
I don't agree with changes #1 and #2.
If you are going to go to a model where every single configuration
operation is recorded in software and performed at resume time, then
really do it and fix it in the whole driver. As currently coded you
are leaving lots of known bugs in the driver.
#2 is even a worse situation. If you are going to handle things this
way you must sync the counters when the suspend happens, so that the
statistics get call receives up to date values.
next prev parent reply other threads:[~2016-03-01 20:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 8:40 [PATCH net 0/3] r8169:issues fix Chunhao Lin
2016-02-26 8:40 ` [PATCH net 1/3] r8169:fix nic sometimes doesn't work after changing the mac address Chunhao Lin
2016-02-26 23:31 ` Francois Romieu
2016-02-27 18:19 ` Hau
2016-02-26 8:40 ` [PATCH net 2/3] r8169:eliminate error message in using ethtool -S when nic is down Chunhao Lin
2016-02-26 8:40 ` [PATCH net 3/3] r8169: Enable RX_MULTI_EN for RTL_GIGA_MAC_VER_41~48 Chunhao Lin
2016-03-01 20:24 ` David Miller [this message]
2016-03-02 16:32 ` [PATCH net 0/3] r8169:issues fix Hau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160301.152453.1743613743070525198.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hau@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).