From: David Miller <davem@davemloft.net>
To: john.fastabend@gmail.com
Cc: jiri@resnulli.us, daniel@iogearbox.net,
simon.horman@netronome.com, netdev@vger.kernel.org,
alexei.starovoitov@gmail.com, jhs@mojatatu.com
Subject: Re: [net-next PATCH v3 0/3] tc software only
Date: Tue, 01 Mar 2016 16:06:04 -0500 (EST) [thread overview]
Message-ID: <20160301.160604.1392938206098066808.davem@davemloft.net> (raw)
In-Reply-To: <20160226154858.5338.90569.stgit@john-Precision-Tower-5810>
From: John Fastabend <john.fastabend@gmail.com>
Date: Fri, 26 Feb 2016 07:53:26 -0800
> This adds a software only flag to tc but incorporates a bunch of comments
> from the original attempt at this.
>
> First instead of having the offload decision logic be embedded in cls_u32
> I lifted into cls_pkt.h so it can be used anywhere and named the flag
> TCA_CLS_FLAGS_SKIP_HW (Thanks Jiri ;)
>
> In order to do this I put the flag defines in pkt_cls.h as well. However
> it was suggested that perhaps these flags could be lifted into the
> upper layer of TCA_ as well but I'm afraid this can not be done with
> existing tc design as far as I can tell. The problem is the filters are
> packed and unpacked in the classifier specific code and pushing the flags
> through the high level doesn't seem easily doable. And we already have
> this design where classifiers handle generic options such as actions and
> policers. So I think adding one more thing here is OK as 'tc', et. al.
> already know how to handle this type of thing.
Series applied, thanks John.
prev parent reply other threads:[~2016-03-01 21:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 15:53 [net-next PATCH v3 0/3] tc software only John Fastabend
2016-02-26 15:53 ` [net-next PATCH v3 1/3] net: sched: consolidate offload decision in cls_u32 John Fastabend
2016-02-26 15:55 ` Jiri Pirko
2016-02-26 17:39 ` Cong Wang
2016-02-27 4:24 ` John Fastabend
2016-02-28 4:28 ` Cong Wang
2016-02-29 18:40 ` John Fastabend
2016-02-29 18:58 ` Jiri Pirko
2016-02-29 21:25 ` Cong Wang
2016-02-29 23:40 ` John Fastabend
2016-02-26 15:54 ` [net-next PATCH v3 2/3] net: cls_u32: move TC offload feature bit into cls_u32 offload logic John Fastabend
2016-02-26 15:56 ` Jiri Pirko
2016-02-26 15:54 ` [net-next PATCH v3 3/3] net: sched: cls_u32 add bit to specify software only rules John Fastabend
2016-02-26 15:58 ` Jiri Pirko
2016-03-01 21:06 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160301.160604.1392938206098066808.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexei.starovoitov@gmail.com \
--cc=daniel@iogearbox.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=simon.horman@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).