* [net-next] net: pktgen: use reset to set mac header
@ 2016-02-29 8:21 Zhang Shengju
2016-03-01 22:47 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Zhang Shengju @ 2016-02-29 8:21 UTC (permalink / raw)
To: davem, netdev
Since offset is zero, it's not necessary to use set function.
Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
---
net/core/pktgen.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index 1474cfd..20999aa 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -2856,7 +2856,7 @@ static struct sk_buff *fill_packet_ipv4(struct net_device *odev,
*vlan_encapsulated_proto = htons(ETH_P_IP);
}
- skb_set_mac_header(skb, 0);
+ skb_reset_mac_header(skb);
skb_set_network_header(skb, skb->len);
iph = (struct iphdr *) skb_put(skb, sizeof(struct iphdr));
@@ -2983,7 +2983,7 @@ static struct sk_buff *fill_packet_ipv6(struct net_device *odev,
*vlan_encapsulated_proto = htons(ETH_P_IPV6);
}
- skb_set_mac_header(skb, 0);
+ skb_reset_mac_header(skb);
skb_set_network_header(skb, skb->len);
iph = (struct ipv6hdr *) skb_put(skb, sizeof(struct ipv6hdr));
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [net-next] net: pktgen: use reset to set mac header
2016-02-29 8:21 [net-next] net: pktgen: use reset to set mac header Zhang Shengju
@ 2016-03-01 22:47 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-03-01 22:47 UTC (permalink / raw)
To: zhangshengju; +Cc: netdev
From: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Date: Mon, 29 Feb 2016 08:21:30 +0000
> Since offset is zero, it's not necessary to use set function.
>
> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-01 22:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-29 8:21 [net-next] net: pktgen: use reset to set mac header Zhang Shengju
2016-03-01 22:47 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).