netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
	john fastabend <john.fastabend@gmail.com>,
	John Fastabend <john.r.fastabend@intel.com>
Subject: Re: net-next build failure due to 16e5cc64?
Date: Tue, 1 Mar 2016 13:41:19 -0500	[thread overview]
Message-ID: <20160301184119.GS16369@oracle.com> (raw)
In-Reply-To: <CAM_iQpXwd9fQqEh1o56fVqoxUYC5ctY9wqjkAA7UeGru+T8bjw@mail.gmail.com>

On (03/01/16 10:23), Cong Wang wrote:
> > The compiler error is for fields within the union which lacks
> > both a tag and a union-name.  So I'm not sure how the above will
> > help.
> >
> 
> Come on.. we have plenty of such anonymous unions in skbuff.h...

I realize that, even netdevice.h itself has other instances.
Thus I dont understand why this one generated a compiler error 
for me.  Thus I was wondering why others had not run into this
and not suggesting it should be patched.

However, changing the way we set up type etc. doesnt seem relevant
to what the compiler is flagging.

--Sowmini

  reply	other threads:[~2016-03-01 18:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-01 17:42 net-next build failure due to 16e5cc64? Sowmini Varadhan
2016-03-01 18:13 ` Cong Wang
2016-03-01 18:16   ` Cong Wang
2016-03-01 18:21   ` Sowmini Varadhan
2016-03-01 18:23     ` Cong Wang
2016-03-01 18:41       ` Sowmini Varadhan [this message]
2016-03-01 18:51         ` Cong Wang
2016-03-01 19:09           ` Sowmini Varadhan
2016-03-01 19:29             ` Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160301184119.GS16369@oracle.com \
    --to=sowmini.varadhan@oracle.com \
    --cc=john.fastabend@gmail.com \
    --cc=john.r.fastabend@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).