From: David Miller <davem@davemloft.net>
To: nicolas.dichtel@6wind.com
Cc: netdev@vger.kernel.org, ben@decadent.org.uk, kan.liang@intel.com
Subject: Re: [PATCH net-next v2 1/2] uapi: define DIV_ROUND_UP for userland
Date: Thu, 03 Mar 2016 16:43:52 -0500 (EST) [thread overview]
Message-ID: <20160303.164352.1296057971694454944.davem@davemloft.net> (raw)
In-Reply-To: <1456850464-23003-1-git-send-email-nicolas.dichtel@6wind.com>
From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Date: Tue, 1 Mar 2016 17:41:03 +0100
> DIV_ROUND_UP is defined in linux/kernel.h only for the kernel.
> When ethtool.h is included by a userland app, we got the following error:
>
> include/linux/ethtool.h:1218:8: error: variably modified 'queue_mask' at file scope
> __u32 queue_mask[DIV_ROUND_UP(MAX_NUM_QUEUE, 32)];
> ^
>
> Let's add a common definition in uapi and use it everywhere.
>
> Fixes: ac2c7ad0e5d6 ("net/ethtool: introduce a new ioctl for per queue setting")
> CC: Kan Liang <kan.liang@intel.com>
> Suggested-by: Ben Hutchings <ben@decadent.org.uk>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Applied.
next prev parent reply other threads:[~2016-03-03 21:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 15:20 [PATCH net-next] ethtool.h: define DIV_ROUND_UP for userland Nicolas Dichtel
2016-03-01 15:29 ` Ben Hutchings
2016-03-01 16:41 ` [PATCH net-next v2 1/2] uapi: " Nicolas Dichtel
2016-03-01 16:41 ` [PATCH net-next v2 2/2] ethtool.h: define INT_MAX " Nicolas Dichtel
2016-03-03 21:43 ` David Miller
2016-03-03 21:43 ` David Miller [this message]
2016-03-03 22:08 ` [PATCH net-next v2 1/2] uapi: define DIV_ROUND_UP " David Miller
2016-03-04 10:52 ` [PATCH net-next v3 0/4] uapi: consolidate DIV_ROUND_UP definition Nicolas Dichtel
2016-03-04 10:52 ` [PATCH net-next v3 1/4] uapi: define DIV_ROUND_UP for userland Nicolas Dichtel
2016-03-04 10:52 ` [PATCH net-next v3 2/4] cxgb4i: don't redefine DIV_ROUND_UP Nicolas Dichtel
2016-03-04 10:52 ` [PATCH net-next v3 3/4] drm/vmwgfx: remove userland definition of DIV_ROUND_UP Nicolas Dichtel
2016-03-04 21:36 ` Emil Velikov
2016-03-04 10:52 ` [PATCH net-next v3 4/4] ethtool.h: define INT_MAX for userland Nicolas Dichtel
2016-03-04 13:10 ` Nikolay Aleksandrov
2016-03-04 21:10 ` [PATCH net-next v3 0/4] uapi: consolidate DIV_ROUND_UP definition David Miller
2016-03-01 16:42 ` [PATCH net-next] ethtool.h: define DIV_ROUND_UP for userland David Miller
2016-03-01 17:14 ` Ben Hutchings
2016-03-01 19:48 ` David Miller
2016-03-01 20:06 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160303.164352.1296057971694454944.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ben@decadent.org.uk \
--cc=kan.liang@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).