netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: gorcunov@gmail.com
Cc: netdev@vger.kernel.org, solar@openwall.com, vvs@virtuozzo.com,
	avagin@virtuozzo.com, xemul@virtuozzo.com,
	vdavydov@virtuozzo.com, khorenko@virtuozzo.com,
	eric.dumazet@gmail.com
Subject: Re: [RFC] net: ipv4 -- Introduce ifa limit per net
Date: Fri, 04 Mar 2016 17:50:32 -0500 (EST)	[thread overview]
Message-ID: <20160304.175032.1728003538386465719.davem@davemloft.net> (raw)
In-Reply-To: <20160304213920.GJ4184@uranus.lan>

From: Cyrill Gorcunov <gorcunov@gmail.com>
Date: Sat, 5 Mar 2016 00:39:20 +0300

> Currenlty all the kernels (including vanilla) free ifa
> list under rtln_lock() taken which takes a huge time
> to release all entries when we stop the container.
> Moreover it's allowed to create unlimited number
> of addresses from inside of net-namespace if
> CAP-NET_ADMIN granted (which is common for containers).
> 
> Lets introduce per-net limit (4096 by default)
> of addresses, which can be tuned up via sysfs
> entry /proc/sys/net/ipv4/ifa_limit.
> 
> Reported-by: Solar Designer <solar@openwall.com>
> Signed-off-by: Cyrill Gorcunov <gorcunov@virtuozzo.com>

Arbitrary limits are... arbitrary.

If the freeing loop is the issue, splice the list at teardown and
process that list asynchronously via a workqueue or similar.

Thanks.

  reply	other threads:[~2016-03-04 22:50 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-04 21:39 [RFC] net: ipv4 -- Introduce ifa limit per net Cyrill Gorcunov
2016-03-04 22:50 ` David Miller [this message]
2016-03-05  0:08   ` Eric Dumazet
2016-03-05  4:11     ` David Miller
2016-03-05  7:18       ` Cyrill Gorcunov
2016-03-05 15:57       ` Cyrill Gorcunov
2016-03-05 16:33         ` David Miller
2016-03-05 17:00           ` Cyrill Gorcunov
2016-03-05 18:44           ` Cyrill Gorcunov
2016-03-06 10:09             ` Cyrill Gorcunov
2016-03-06 16:23               ` Eric Dumazet
2016-03-06 17:06                 ` Cyrill Gorcunov
2016-03-09 16:39                   ` Cyrill Gorcunov
2016-03-09 16:51                     ` Cyrill Gorcunov
2016-03-09 16:58                     ` Alexei Starovoitov
2016-03-09 17:09                       ` Cyrill Gorcunov
2016-03-09 17:24                         ` David Miller
2016-03-09 17:53                           ` Cyrill Gorcunov
2016-03-09 19:55                             ` Cyrill Gorcunov
2016-03-09 20:27                             ` David Miller
2016-03-09 20:41                               ` Cyrill Gorcunov
2016-03-09 20:47                                 ` David Miller
2016-03-09 20:57                                   ` Cyrill Gorcunov
2016-03-09 21:10                                     ` David Miller
2016-03-09 21:16                                       ` Cyrill Gorcunov
2016-03-10 10:20                                         ` Cyrill Gorcunov
2016-03-10 11:03                                           ` Cyrill Gorcunov
2016-03-10 15:09                                             ` Cyrill Gorcunov
2016-03-10 18:01                                               ` David Miller
2016-03-10 18:48                                                 ` Cyrill Gorcunov
2016-03-10 19:02                                                 ` Cong Wang
2016-03-10 19:55                                                   ` David Miller
2016-03-10 20:01                                                     ` Cyrill Gorcunov
2016-03-10 20:03                                                       ` David Miller
2016-03-10 20:13                                                         ` Cyrill Gorcunov
2016-03-10 20:19                                                           ` Cyrill Gorcunov
2016-03-10 21:05                                                           ` David Miller
2016-03-10 21:19                                                             ` Cyrill Gorcunov
2016-03-10 21:59                                                               ` Cyrill Gorcunov
2016-03-10 22:36                                                                 ` David Miller
2016-03-10 22:40                                                                   ` Cyrill Gorcunov
2016-03-11 20:40                                                                     ` David Miller
2016-03-11 20:58                                                                       ` Florian Westphal
2016-03-11 21:00                                                                       ` Cyrill Gorcunov
2016-03-11 21:22                                                                       ` Cyrill Gorcunov
2016-03-11 21:59                                                                         ` Cyrill Gorcunov
2016-03-14  3:29                                                                           ` David Miller
2016-03-10 21:09                                                     ` Cong Wang
2016-03-09 17:19                     ` David Miller
2016-03-05  6:58   ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160304.175032.1728003538386465719.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=avagin@virtuozzo.com \
    --cc=eric.dumazet@gmail.com \
    --cc=gorcunov@gmail.com \
    --cc=khorenko@virtuozzo.com \
    --cc=netdev@vger.kernel.org \
    --cc=solar@openwall.com \
    --cc=vdavydov@virtuozzo.com \
    --cc=vvs@virtuozzo.com \
    --cc=xemul@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).