From mboxrd@z Thu Jan 1 00:00:00 1970 From: kbuild test robot Subject: [PATCH] infiniband: hns: fix returnvar.cocci warnings Date: Fri, 4 Mar 2016 20:10:57 +0800 Message-ID: <20160304121057.GA3950@lkp-nhm1.intel.com> References: <201603042059.A0IVxKAt%fengguang.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kbuild-all@01.org, dledford@redhat.com, sean.hefty@intel.com, hal.rosenstock@gmail.com, davem@davemloft.net, jeffrey.t.kirsher@intel.com, jiri@mellanox.com, ogerlitz@mellanox.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, gongyangming@huawei.com, xiaokun@huawei.com, tangchaofei@huawei.com, oulijun@huawei.com, haifeng.wei@huawei.com, yisen.zhuang@huawei.com, yankejian@huawei.com, lisheng011@huawei.com, charles.chenxin@huawei.com, linuxarm@huawei.com To: "Wei Hu(Xavier)" Return-path: Content-Disposition: inline In-Reply-To: <1457080877-13456-5-git-send-email-xavier.huwei@huawei.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org drivers/infiniband/hw/hisilicon/hns/hns_roce_v1_hw.c:1562:5-8: Unneeded variable: "ret". Return "0" on line 1587 Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci CC: Wei Hu(Xavier) Signed-off-by: Fengguang Wu --- Please take the patch only if it's a positive warning. Thanks! hns_roce_v1_hw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/infiniband/hw/hisilicon/hns/hns_roce_v1_hw.c +++ b/drivers/infiniband/hw/hisilicon/hns/hns_roce_v1_hw.c @@ -1559,7 +1559,6 @@ int hns_roce_v1_req_notify_cq(struct ib_ struct hns_roce_cq *hr_cq = to_hr_cq(ibcq); u32 notification_flag; u32 doorbell[2]; - int ret = 0; notification_flag = (flags & IB_CQ_SOLICITED_MASK) == IB_CQ_SOLICITED ? CQ_DB_REQ_NOT : CQ_DB_REQ_NOT_SOL; @@ -1584,7 +1583,7 @@ int hns_roce_v1_req_notify_cq(struct ib_ hns_roce_write64_k(doorbell, hr_cq->cq_db_l); - return ret; + return 0; } static int hns_roce_v1_poll_one(