From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Phil Sutter <phil@nwl.cc>
Cc: netdev@vger.kernel.org, Daniel Borkmann <daniel@iogearbox.net>,
Jamal Hadi Salim <jhs@mojatatu.com>
Subject: Re: [iproute PATCH 12/12] doc: Add my article about tc, filters and actions
Date: Fri, 4 Mar 2016 17:40:13 -0800 [thread overview]
Message-ID: <20160305014011.GA63767@ast-mbp.thefacebook.com> (raw)
In-Reply-To: <1457093507-25601-13-git-send-email-phil@nwl.cc>
On Fri, Mar 04, 2016 at 01:11:47PM +0100, Phil Sutter wrote:
> Signed-off-by: Phil Sutter <phil@nwl.cc>
great to see TC doc!
Few comments:
> +TC, the Traffic Control utility, has been there for a very long time - forever
> +in my humble perception. It is still (and has ever been if I'm not mistaken) the
> +only tool to configure QoS in Linux.
please make the doc less subjective. The above paragraph can be removed.
> +\section*{Conclusion}
> +
> +My personal impression is that although the \cmd{tc} utility is an absolute
> +necessity for anyone aiming at doing QoS in Linux professionally, there are way
> +too many loose ends and trip wires present in it's environment. Contributing to
> +this is the fact, that much of the non-essential functionality is redundantly
> +available in netfilter. Another problem which adds weight to the first one is a
> +general lack of documentation. Of course, there are many HOWTOs and guides in
> +the internet, but since it's often not clear how up to date these are, I prefer
> +the usual resources such as man or info pages. Surely nothing one couldn't fix
> +in hindsight, but quality certainly suffers if the original author of the code
> +does not or can not contribute to that.
This one is also very subjective and not suitable for the iproute2 doc.
Please remove it.
> +All that being said, once the steep learning curve has been mastered, the
> +conglomerate of (classful) qdiscs, filters and actions provides a highly
> +sophisticated and flexible infrastructure to perform QoS, which plays nicely
> +along with routing and firewalling setups.
The rest of the doc is great. Thank you.
next prev parent reply other threads:[~2016-03-05 1:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 12:11 [iproute PATCH 00/12] Add tc action man pages Phil Sutter
2016-03-04 12:11 ` [iproute PATCH 01/12] man: Add a man page for the connmark action Phil Sutter
2016-03-07 11:41 ` Jamal Hadi Salim
2016-03-04 12:11 ` [iproute PATCH 02/12] man: Add a man page for the csum action Phil Sutter
2016-03-07 11:45 ` Jamal Hadi Salim
2016-03-04 12:11 ` [iproute PATCH 03/12] man: Add a man page for the mirred action Phil Sutter
2016-03-07 12:06 ` Jamal Hadi Salim
2016-03-04 12:11 ` [iproute PATCH 04/12] man: Add a man page for the nat action Phil Sutter
2016-03-04 12:11 ` [iproute PATCH 05/12] man: Add a man page for the pedit action Phil Sutter
2016-03-04 12:11 ` [iproute PATCH 06/12] man: Add a man page for the police action Phil Sutter
2016-03-07 12:23 ` Jamal Hadi Salim
2016-03-04 12:11 ` [iproute PATCH 07/12] man: Add a man page for the simple action Phil Sutter
2016-03-04 12:11 ` [iproute PATCH 08/12] man: Add a man page for the skbedit action Phil Sutter
2016-03-04 12:11 ` [iproute PATCH 09/12] man: Add a man page for the vlan action Phil Sutter
2016-03-04 12:11 ` [iproute PATCH 10/12] man: Add a man page for the xt action Phil Sutter
2016-03-04 12:11 ` [iproute PATCH 11/12] man: ship action man pages Phil Sutter
2016-03-04 12:11 ` [iproute PATCH 12/12] doc: Add my article about tc, filters and actions Phil Sutter
2016-03-05 1:40 ` Alexei Starovoitov [this message]
2016-03-05 2:21 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160305014011.GA63767@ast-mbp.thefacebook.com \
--to=alexei.starovoitov@gmail.com \
--cc=daniel@iogearbox.net \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox