From: David Miller <davem@davemloft.net>
To: Kyeong.Yoo@alliedtelesis.co.nz
Cc: netdev@vger.kernel.org
Subject: Re: [net-next PATCH v2] net_sched: dsmark: use qdisc_dequeue_peeked()
Date: Sun, 06 Mar 2016 22:49:21 -0500 (EST) [thread overview]
Message-ID: <20160306.224921.2002681200914411743.davem@davemloft.net> (raw)
In-Reply-To: <1457000719.30212.3.camel@kyeongy-dl>
From: Kyeong Yoo <Kyeong.Yoo@alliedtelesis.co.nz>
Date: Thu, 3 Mar 2016 10:25:19 +0000
> This fix is for dsmark similar to commit 3557619f0f6f7496ed453d4825e249
> ("net_sched: prio: use qdisc_dequeue_peeked")
> and makes use of qdisc_dequeue_peeked() instead of direct dequeue() call.
>
> First time, wrr peeks dsmark, which will then peek into sfq.
> sfq dequeues an skb and it's stored in sch->gso_skb.
> Next time, wrr tries to dequeue from dsmark, which will call sfq dequeue
> directly. This results skipping the previously peeked skb.
>
> So changed dsmark dequeue to call qdisc_dequeue_peeked() instead to use
> peeked skb if exists.
>
> Signed-off-by: Kyeong Yoo <kyeong.yoo@alliedtelesis.co.nz>
Your patch is corrupted by your email client, it has MS-DOS style
newlines, etc.
next prev parent reply other threads:[~2016-03-07 3:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 10:25 [net-next PATCH v2] net_sched: dsmark: use qdisc_dequeue_peeked() Kyeong Yoo
2016-03-07 3:49 ` David Miller [this message]
2016-03-07 4:06 ` Kyeong Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160306.224921.2002681200914411743.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Kyeong.Yoo@alliedtelesis.co.nz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox