* [PATCH] net/ethoc: do not free array priv->mdio->irq
@ 2016-03-03 13:43 Colin King
2016-03-03 14:12 ` Tobias Klauser
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Colin King @ 2016-03-03 13:43 UTC (permalink / raw)
To: David S . Miller, Andrew Lunn, Florian Fainelli, Tobias Klauser,
Fabian Frederick, Max Filippov, netdev
Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
priv->mdio->irq used to be allocated and required freeing, but it
is now a fixed sized array and should no longer be free'd.
Issue detected using static analysis with CoverityScan
Fixes: e7f4dc3536a400 ("mdio: Move allocation of interrupts into core")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/ethoc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/ethoc.c b/drivers/net/ethernet/ethoc.c
index 62fa136..41b0106 100644
--- a/drivers/net/ethernet/ethoc.c
+++ b/drivers/net/ethernet/ethoc.c
@@ -1265,7 +1265,6 @@ static int ethoc_remove(struct platform_device *pdev)
if (priv->mdio) {
mdiobus_unregister(priv->mdio);
- kfree(priv->mdio->irq);
mdiobus_free(priv->mdio);
}
if (priv->clk)
--
2.7.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] net/ethoc: do not free array priv->mdio->irq
2016-03-03 13:43 [PATCH] net/ethoc: do not free array priv->mdio->irq Colin King
@ 2016-03-03 14:12 ` Tobias Klauser
2016-03-03 14:27 ` Andrew Lunn
2016-03-07 3:59 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Tobias Klauser @ 2016-03-03 14:12 UTC (permalink / raw)
To: Colin King
Cc: David S . Miller, Andrew Lunn, Florian Fainelli, Fabian Frederick,
Max Filippov, netdev, linux-kernel
On 2016-03-03 at 14:43:34 +0100, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> priv->mdio->irq used to be allocated and required freeing, but it
> is now a fixed sized array and should no longer be free'd.
>
> Issue detected using static analysis with CoverityScan
>
> Fixes: e7f4dc3536a400 ("mdio: Move allocation of interrupts into core")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Tobias Klauser <tklauser@distanz.ch>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net/ethoc: do not free array priv->mdio->irq
2016-03-03 13:43 [PATCH] net/ethoc: do not free array priv->mdio->irq Colin King
2016-03-03 14:12 ` Tobias Klauser
@ 2016-03-03 14:27 ` Andrew Lunn
2016-03-07 3:59 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2016-03-03 14:27 UTC (permalink / raw)
To: Colin King
Cc: David S . Miller, Florian Fainelli, Tobias Klauser,
Fabian Frederick, Max Filippov, netdev, linux-kernel
On Thu, Mar 03, 2016 at 01:43:34PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> priv->mdio->irq used to be allocated and required freeing, but it
> is now a fixed sized array and should no longer be free'd.
>
> Issue detected using static analysis with CoverityScan
>
> Fixes: e7f4dc3536a400 ("mdio: Move allocation of interrupts into core")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Thanks
Andrew
> ---
> drivers/net/ethernet/ethoc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/ethoc.c b/drivers/net/ethernet/ethoc.c
> index 62fa136..41b0106 100644
> --- a/drivers/net/ethernet/ethoc.c
> +++ b/drivers/net/ethernet/ethoc.c
> @@ -1265,7 +1265,6 @@ static int ethoc_remove(struct platform_device *pdev)
>
> if (priv->mdio) {
> mdiobus_unregister(priv->mdio);
> - kfree(priv->mdio->irq);
> mdiobus_free(priv->mdio);
> }
> if (priv->clk)
> --
> 2.7.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net/ethoc: do not free array priv->mdio->irq
2016-03-03 13:43 [PATCH] net/ethoc: do not free array priv->mdio->irq Colin King
2016-03-03 14:12 ` Tobias Klauser
2016-03-03 14:27 ` Andrew Lunn
@ 2016-03-07 3:59 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2016-03-07 3:59 UTC (permalink / raw)
To: colin.king
Cc: andrew, f.fainelli, tklauser, fabf, jcmvbkbc, netdev,
linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Thu, 3 Mar 2016 13:43:34 +0000
> From: Colin Ian King <colin.king@canonical.com>
>
> priv->mdio->irq used to be allocated and required freeing, but it
> is now a fixed sized array and should no longer be free'd.
>
> Issue detected using static analysis with CoverityScan
>
> Fixes: e7f4dc3536a400 ("mdio: Move allocation of interrupts into core")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-03-07 3:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-03 13:43 [PATCH] net/ethoc: do not free array priv->mdio->irq Colin King
2016-03-03 14:12 ` Tobias Klauser
2016-03-03 14:27 ` Andrew Lunn
2016-03-07 3:59 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).