netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: parthasarathy.bhuvaragan@ericsson.com
Cc: netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net,
	jon.maloy@ericsson.com, maloy@donjonn.com,
	ying.xue@windriver.com
Subject: Re: [PATCH net v1 1/1] tipc: fix nullptr crash during subscription cancel
Date: Sun, 06 Mar 2016 23:01:03 -0500 (EST)	[thread overview]
Message-ID: <20160306.230103.935516724641513071.davem@davemloft.net> (raw)
In-Reply-To: <1457024094-29530-1-git-send-email-parthasarathy.bhuvaragan@ericsson.com>

From: Parthasarathy Bhuvaragan <parthasarathy.bhuvaragan@ericsson.com>
Date: Thu, 3 Mar 2016 17:54:54 +0100

> commit 4d5cfcba2f6e ('tipc: fix connection abort during subscription
> cancel'), removes the check for a valid subscription before calling
> tipc_nametbl_subscribe().
> 
> This will lead to a nullptr exception when we process a
> subscription cancel request. For a cancel request, a null
> subscription is passed to tipc_nametbl_subscribe() resulting
> in exception.
> 
> In this commit, we call tipc_nametbl_subscribe() only for
> a valid subscription.
> 
> Fixes: 4d5cfcba2f6e ('tipc: fix connection abort during subscription cancel')
> Reported-by: Anders Widell <anders.widell@ericsson.com>
> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvaragan@ericsson.com>
> Acked-by: Jon Maloy <jon.maloy@ericsson.com>

Applied.

      reply	other threads:[~2016-03-07  4:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-03 16:54 [PATCH net v1 1/1] tipc: fix nullptr crash during subscription cancel Parthasarathy Bhuvaragan
2016-03-07  4:01 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160306.230103.935516724641513071.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=jon.maloy@ericsson.com \
    --cc=maloy@donjonn.com \
    --cc=netdev@vger.kernel.org \
    --cc=parthasarathy.bhuvaragan@ericsson.com \
    --cc=tipc-discussion@lists.sourceforge.net \
    --cc=ying.xue@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).