From: David Miller <davem@davemloft.net>
To: zhangshengju@cmss.chinamobile.com
Cc: netdev@vger.kernel.org
Subject: Re: [net-next v2] arp: correct return value of arp_rcv
Date: Mon, 07 Mar 2016 14:55:17 -0500 (EST) [thread overview]
Message-ID: <20160307.145517.292313609973580675.davem@davemloft.net> (raw)
In-Reply-To: <1457100474-18580-1-git-send-email-zhangshengju@cmss.chinamobile.com>
From: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Date: Fri, 4 Mar 2016 14:07:54 +0000
> Currently, arp_rcv() always return zero on a packet delivery upcall.
>
> To make its behavior more compliant with the way this API should be
> used, this patch changes this to let it return NET_RX_SUCCESS when the
> packet is proper handled, and NET_RX_DROP otherwise.
>
> v1->v2:
> If sanity check is failed, call kfree_skb() instead of consume_skb(), then
> return the correct return value.
>
> Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Applied, thanks.
prev parent reply other threads:[~2016-03-07 19:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 14:07 [net-next v2] arp: correct return value of arp_rcv Zhang Shengju
2016-03-07 19:55 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160307.145517.292313609973580675.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=zhangshengju@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).