* [PATCH net] ppp: release rtnl mutex when interface creation fails
@ 2016-03-07 18:36 Guillaume Nault
2016-03-07 21:12 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Guillaume Nault @ 2016-03-07 18:36 UTC (permalink / raw)
To: netdev; +Cc: Paul Mackerras, David Miller
Add missing rtnl_unlock() in the error path of ppp_create_interface().
Fixes: 58a89ecaca53 ("ppp: fix lockdep splat in ppp_dev_uninit()")
Signed-off-by: Guillaume Nault <g.nault@alphalink.fr>
---
drivers/net/ppp/ppp_generic.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ppp/ppp_generic.c b/drivers/net/ppp/ppp_generic.c
index e8a5936..d61da9ec 100644
--- a/drivers/net/ppp/ppp_generic.c
+++ b/drivers/net/ppp/ppp_generic.c
@@ -2816,6 +2816,7 @@ static struct ppp *ppp_create_interface(struct net *net, int unit,
out2:
mutex_unlock(&pn->all_ppp_mutex);
+ rtnl_unlock();
free_netdev(dev);
out1:
*retp = ret;
--
2.7.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] ppp: release rtnl mutex when interface creation fails
2016-03-07 18:36 [PATCH net] ppp: release rtnl mutex when interface creation fails Guillaume Nault
@ 2016-03-07 21:12 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-03-07 21:12 UTC (permalink / raw)
To: g.nault; +Cc: netdev, paulus
From: Guillaume Nault <g.nault@alphalink.fr>
Date: Mon, 7 Mar 2016 19:36:44 +0100
> Add missing rtnl_unlock() in the error path of ppp_create_interface().
>
> Fixes: 58a89ecaca53 ("ppp: fix lockdep splat in ppp_dev_uninit()")
> Signed-off-by: Guillaume Nault <g.nault@alphalink.fr>
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-07 21:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-07 18:36 [PATCH net] ppp: release rtnl mutex when interface creation fails Guillaume Nault
2016-03-07 21:12 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).