From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [V2] rtlwifi: pass struct rtl_stats by reference as it is moreefficient Date: Mon, 7 Mar 2016 12:25:56 +0000 (UTC) Message-ID: <20160307122556.D5EFC6060D@smtp.codeaurora.org> References: <1456140946-12509-1-git-send-email-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Larry Finger , Chaoming Li , Priit Laes , linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Colin Ian King Return-path: In-Reply-To: <1456140946-12509-1-git-send-email-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org> Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org > From: Colin Ian King > > passing rtl_stats by value is inefficient; the structure is over 300 > bytes in size and generally just one field (packet_report_type) > is being accessed, so the pass by value is a relatively large overhead. > This change just affects just the rx_command_packet calls. > > Signed-off-by: Colin Ian King > Acked-by: Larry Finger Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html