From: David Miller <davem@davemloft.net>
To: wjeong@barracuda.com, weongyo.linux@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] inet: set `error' value not under lock_sock().
Date: Wed, 09 Mar 2016 15:37:15 -0500 (EST) [thread overview]
Message-ID: <20160309.153715.770009288781656553.davem@davemloft.net> (raw)
In-Reply-To: <20160309182217.GA9708@jwg>
From: Weongyo Jeong <weongyo.linux@gmail.com>
Date: Wed, 9 Mar 2016 10:22:21 -0800
> A trivial patch to set `error' variable while not holding
> lock_sock().
>
> Signed-off-by: Weongyo Jeong <weongyo.linux@gmail.com>
Deferring the assignment means gcc doesn't have to potentially put it
on the stack across the lock_sock() call.
You're making the code worse not better, the assignment into a local
variable is not an expensive operation.
I'm not applying this change, sorry.
next prev parent reply other threads:[~2016-03-09 20:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 18:22 [PATCH] inet: set `error' value not under lock_sock() Weongyo Jeong
2016-03-09 20:37 ` David Miller [this message]
2016-03-09 22:46 ` Weongyo Jeong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160309.153715.770009288781656553.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=weongyo.linux@gmail.com \
--cc=wjeong@barracuda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).