From: Herbert Xu <herbert@gondor.apana.org.au>
To: subashab@codeaurora.org
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Steffen Klassert <steffen.klassert@secunet.com>,
netdev@vger.kernel.org
Subject: Re: [RFC] xfrm: netdevice unregistration during decryption
Date: Wed, 9 Mar 2016 10:20:45 +0800 [thread overview]
Message-ID: <20160309022045.GA29265@gondor.apana.org.au> (raw)
In-Reply-To: <9fb4925ea87677df44c75c435efc329f@codeaurora.org>
On Tue, Mar 08, 2016 at 07:16:23PM -0700, subashab@codeaurora.org wrote:
>
> 2. Encrypted packet queued for decryption (asynchronous)
>
> static int esp_input(struct xfrm_state *x, struct sk_buff *skb)
> ...
> aead_request_set_callback(req, 0, esp_input_done, skb);
I suppose we'll have to hold onto the device at this point. We
may have to hold onto other resources too.
> Would it make sense here to detect the device going away here using a
> netdev notifier callback and free the packets after the asynchronous
> callback returns.
The same path is used for synchronous processing so you can't just
change it to netif_rx_ni unconditionally.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2016-03-09 2:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 2:16 [RFC] xfrm: netdevice unregistration during decryption subashab
2016-03-09 2:20 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160309022045.GA29265@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=subashab@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox