From: David Miller <davem@davemloft.net>
To: Aaron.Young@oracle.com
Cc: netdev@vger.kernel.org, sowmini.varadhan@oracle.com,
alexandre.chartre@oracle.com, rashmi.narasimhan@oracle.com
Subject: Re: [PATCH net-next 2/4] ldmvsw: Make sunvnet_common compatible with ldmvsw
Date: Fri, 11 Mar 2016 14:27:33 -0500 (EST) [thread overview]
Message-ID: <20160311.142733.1237549201193012342.davem@davemloft.net> (raw)
In-Reply-To: <85723889cbcaab6d1f72581f5d34b07c7dc67f6f.1457401532.git.Aaron.Young@oracle.com>
From: Aaron Young <Aaron.Young@oracle.com>
Date: Tue, 8 Mar 2016 07:02:34 -0800
> @@ -719,12 +720,13 @@ static void maybe_tx_wakeup(struct vnet_port *port)
> __netif_tx_unlock(txq);
> }
>
> -static inline bool port_is_up(struct vnet_port *vnet)
> +inline bool port_is_up_common(struct vnet_port *vnet)
All of these things in foo.c files shouldn't have an inline attribute.
> {
> struct vio_driver_state *vio = &vnet->vio;
>
> return !!(vio->hs_state & VIO_HS_COMPLETE);
> }
> +EXPORT_SYMBOL(port_is_up_common);
Especially if they are also exported.
Need to use EXPORT_SYMBOL_GPL() here as well, but I seriously think you need to rename
this function in order to not pollute the global namespace of exported kernel symbols.
You need to add a suitable prefix such as sunvnet_*() or whatever.
next prev parent reply other threads:[~2016-03-11 19:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 15:02 [PATCH net-next 0/4] ldmvsw: Add ldmvsw driver Aaron Young
2016-03-08 15:02 ` [PATCH net-next 1/4] ldmvsw: Split sunvnet driver into common code Aaron Young
2016-03-11 19:26 ` David Miller
2016-03-08 15:02 ` [PATCH net-next 2/4] ldmvsw: Make sunvnet_common compatible with ldmvsw Aaron Young
2016-03-11 19:27 ` David Miller [this message]
2016-03-08 15:02 ` [PATCH net-next 3/4] ldmvsw: Add ldmvsw.c driver code Aaron Young
2016-03-11 19:30 ` David Miller
2016-03-11 20:46 ` aaron.young
2016-03-08 15:02 ` [PATCH net-next 4/4] ldmvsw: Checkpatch sunvnet.c and sunvnet_common.c Aaron Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160311.142733.1237549201193012342.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Aaron.Young@oracle.com \
--cc=alexandre.chartre@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=rashmi.narasimhan@oracle.com \
--cc=sowmini.varadhan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).