From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: netdev@vger.kernel.org, rds-devel@oss.oracle.com
Cc: sowmini.varadhan@oracle.com, santosh.shilimkar@oracle.com,
davem@davemloft.net
Subject: [PATCH net-next] rds-tcp: Add module parameters to control sndbuf/rcvbuf size of RDS-TCP socket
Date: Fri, 11 Mar 2016 13:29:49 -0500 [thread overview]
Message-ID: <20160311182949.GG3383@oracle.com> (raw)
Some payload sizes/patterns stand to gain performance benefits by
tuning the size of the TCP socket buffers, so this commit adds
module parameters to customize those values when desired.
Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
---
net/rds/tcp.c | 16 +++++++++++++++-
1 files changed, 15 insertions(+), 1 deletions(-)
diff --git a/net/rds/tcp.c b/net/rds/tcp.c
index ad60299..b59e7a2 100644
--- a/net/rds/tcp.c
+++ b/net/rds/tcp.c
@@ -52,7 +52,13 @@ static LIST_HEAD(rds_tcp_conn_list);
static struct kmem_cache *rds_tcp_conn_slab;
-#define RDS_TCP_DEFAULT_BUFSIZE (128 * 1024)
+static int sndbuf_size = 16384;
+module_param(sndbuf_size, int, 0444);
+MODULE_PARM_DESC(sndbuf_size, "SO_SNDBUF size of kernel tcp socket");
+
+static int rcvbuf_size = 87380;
+module_param(rcvbuf_size, int, 0444);
+MODULE_PARM_DESC(rcvbuf_size, "SO_RCVBUF size of kernel tcp socket");
/* doing it this way avoids calling tcp_sk() */
void rds_tcp_nonagle(struct socket *sock)
@@ -72,7 +78,15 @@ void rds_tcp_nonagle(struct socket *sock)
*/
void rds_tcp_tune(struct socket *sock)
{
+ struct sock *sk = sock->sk;
+
rds_tcp_nonagle(sock);
+
+ lock_sock(sk);
+ sk->sk_sndbuf = sndbuf_size;
+ sk->sk_rcvbuf = rcvbuf_size;
+ sk->sk_userlocks |= SOCK_SNDBUF_LOCK | SOCK_RCVBUF_LOCK;
+ release_sock(sk);
}
u32 rds_tcp_snd_nxt(struct rds_tcp_connection *tc)
--
1.7.1
next reply other threads:[~2016-03-11 18:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 18:29 Sowmini Varadhan [this message]
2016-03-11 19:09 ` [PATCH net-next] rds-tcp: Add module parameters to control sndbuf/rcvbuf size of RDS-TCP socket Stephen Hemminger
2016-03-11 19:12 ` Sowmini Varadhan
2016-03-12 2:43 ` Sowmini Varadhan
2016-03-12 3:21 ` Tom Herbert
2016-03-12 3:44 ` Sowmini Varadhan
2016-03-12 4:07 ` Tom Herbert
2016-03-12 4:39 ` Sowmini Varadhan
2016-03-14 17:57 ` Tom Herbert
2016-03-14 18:06 ` Sowmini Varadhan
2016-03-14 18:59 ` David Miller
2016-03-11 19:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160311182949.GG3383@oracle.com \
--to=sowmini.varadhan@oracle.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
--cc=santosh.shilimkar@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).