From: David Miller <davem@davemloft.net>
To: mahesh@bandewar.net
Cc: maheshb@google.com, edumazet@google.com, netdev@vger.kernel.org
Subject: Re: [PATCH next v2 0/7] Introduce l3_dev pointer for L3 processing
Date: Sun, 13 Mar 2016 21:50:33 -0400 (EDT) [thread overview]
Message-ID: <20160313.215033.17951850162749485.davem@davemloft.net> (raw)
In-Reply-To: <1457560189-12870-1-git-send-email-mahesh@bandewar.net>
From: Mahesh Bandewar <mahesh@bandewar.net>
Date: Wed, 9 Mar 2016 13:49:49 -0800
> This does happen as expected for egress traffic however on ingress
> traffic, the IPvlan packet-handler changes the skb->dev and this
> forces packet to be processed with the IPvlan slave and it's
> associated ns. This causes above mentioned problem and few other
> which are not yet reported / attempted. e.g. IPsec with L3 mode or
> even ingress routing.
And now your changes make it so that we can't run netfilter rules on
the slave's device within the slave's ns.
If someone is doing that now you're breaking things for them.
It doesn't matter whether doing so or not makes sense.
You're going to have to find a way to do both, and also I'm concerned
about how you're leaking the source namespace's "stuff" into the
destination's. That's very worrisome to me.
There is no way I'm applying this as-is, sorry.
next prev parent reply other threads:[~2016-03-14 1:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 21:49 [PATCH next v2 0/7] Introduce l3_dev pointer for L3 processing Mahesh Bandewar
2016-03-10 9:47 ` Nicolas Dichtel
2016-03-10 21:29 ` Cong Wang
2016-03-14 0:01 ` Mahesh Bandewar
2016-03-14 18:13 ` Cong Wang
2016-03-13 23:44 ` Mahesh Bandewar
2016-03-14 1:50 ` David Miller [this message]
2016-03-14 2:29 ` Mahesh Bandewar
2016-03-14 3:53 ` David Miller
2016-03-14 17:57 ` Mahesh Bandewar
2016-03-17 8:47 ` Nicolas Dichtel
2016-03-14 18:15 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160313.215033.17951850162749485.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=mahesh@bandewar.net \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).