From: David Miller <davem@davemloft.net>
To: maheshb@google.com
Cc: mahesh@bandewar.net, edumazet@google.com, netdev@vger.kernel.org
Subject: Re: [PATCH next v2 0/7] Introduce l3_dev pointer for L3 processing
Date: Sun, 13 Mar 2016 23:53:58 -0400 (EDT) [thread overview]
Message-ID: <20160313.235358.1007563444789525672.davem@davemloft.net> (raw)
In-Reply-To: <CAF2d9jhtvvEdmwP8OrOcUEn+P-Di0TRnjR7-RpcJrKJ3+HAN-Q@mail.gmail.com>
From: Mahesh Bandewar <maheshb@google.com>
Date: Sun, 13 Mar 2016 19:29:58 -0700
> On Sun, Mar 13, 2016 at 6:50 PM, David Miller <davem@davemloft.net> wrote:
>> It doesn't matter whether doing so or not makes sense.
>>
>> You're going to have to find a way to do both, and also I'm concerned
>> about how you're leaking the source namespace's "stuff" into the
>> destination's. That's very worrisome to me.
>
> If we add a new mode (e.g. L3s) and preserve current mode as is it,
> then that should address your first concern.
Also, I don't want all of this device translation stuff all over the
place.
Furthermore, when you walk across the ns boundary, that old device has
to disappear. That's why that is the device assigned to skb->dev.
Please stop pretending that this device switching is ok, it's not.
next prev parent reply other threads:[~2016-03-14 3:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 21:49 [PATCH next v2 0/7] Introduce l3_dev pointer for L3 processing Mahesh Bandewar
2016-03-10 9:47 ` Nicolas Dichtel
2016-03-10 21:29 ` Cong Wang
2016-03-14 0:01 ` Mahesh Bandewar
2016-03-14 18:13 ` Cong Wang
2016-03-13 23:44 ` Mahesh Bandewar
2016-03-14 1:50 ` David Miller
2016-03-14 2:29 ` Mahesh Bandewar
2016-03-14 3:53 ` David Miller [this message]
2016-03-14 17:57 ` Mahesh Bandewar
2016-03-17 8:47 ` Nicolas Dichtel
2016-03-14 18:15 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160313.235358.1007563444789525672.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=mahesh@bandewar.net \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).