From: Andrew Lunn <andrew@lunn.ch>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH ethtool 1/2] Remove short option -I for PHY statistics
Date: Sun, 13 Mar 2016 17:09:56 +0100 [thread overview]
Message-ID: <20160313160956.GH9674@lunn.ch> (raw)
In-Reply-To: <20160313160120.GB21187@decadent.org.uk>
On Sun, Mar 13, 2016 at 04:01:20PM +0000, Ben Hutchings wrote:
> It's not mnemonic and there's no requirement to have short options
> for every command.
>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Thanks
Andrew
> ---
> ethtool.8.in | 4 ++--
> ethtool.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/ethtool.8.in b/ethtool.8.in
> index 2316556d65de..e44db99dc5d6 100644
> --- a/ethtool.8.in
> +++ b/ethtool.8.in
> @@ -220,7 +220,7 @@ ethtool \- query or control network driver and hardware settings
> .B ethtool \-S|\-\-statistics
> .I devname
> .HP
> -.B ethtool \-I|\-\-phy-statistics
> +.B \-\-phy\-statistics
> .I devname
> .HP
> .B ethtool \-t|\-\-test
> @@ -495,7 +495,7 @@ auto-negotiation is enabled.
> Queries the specified network device for NIC- and driver-specific
> statistics.
> .TP
> -.B \-I \-\-phy\-statistics
> +.B \-\-phy\-statistics
> Queries the specified network device for PHY specific statistics.
> .TP
> .B \-t \-\-test
> diff --git a/ethtool.c b/ethtool.c
> index 480c14c8d30c..1c988f7d8a9d 100644
> --- a/ethtool.c
> +++ b/ethtool.c
> @@ -4136,7 +4136,7 @@ static const struct option {
> { "-t|--test", 1, do_test, "Execute adapter self test",
> " [ online | offline | external_lb ]\n" },
> { "-S|--statistics", 1, do_gstats, "Show adapter statistics" },
> - { "-I|--phy-statistics", 1, do_gphystats,
> + { "--phy-statistics", 1, do_gphystats,
> "Show phy statistics" },
> { "-n|-u|--show-nfc|--show-ntuple", 1, do_grxclass,
> "Show Rx network flow classification options or rules",
>
next prev parent reply other threads:[~2016-03-13 16:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 11:58 [PATCH 0/2] ethtool(1) support for reading Phy stats Andrew Lunn
2015-12-23 11:58 ` [PATCH 1/2] ethtool-copy.h: sync with net Andrew Lunn
2015-12-23 11:58 ` [PATCH 2/2] ethtool: Add PHY statistics support Andrew Lunn
2016-03-13 15:50 ` Ben Hutchings
2016-03-13 16:08 ` Andrew Lunn
2016-03-13 16:01 ` [PATCH ethtool 1/2] Remove short option -I for PHY statistics Ben Hutchings
2016-03-13 16:09 ` Andrew Lunn [this message]
2016-03-13 16:01 ` [PATCH ethtool 2/2] Refactor do_gstats() and do_gphystats() to avoid code duplication Ben Hutchings
2016-03-13 16:12 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160313160956.GH9674@lunn.ch \
--to=andrew@lunn.ch \
--cc=ben@decadent.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).