From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] net: diag: add a scheduling point in inet_diag_dump_icsk()
Date: Mon, 14 Mar 2016 19:38:37 -0400 (EDT) [thread overview]
Message-ID: <20160314.193837.2161977859793491820.davem@davemloft.net> (raw)
In-Reply-To: <1457995200.31401.28.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 14 Mar 2016 15:40:00 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> On loaded TCP servers, looking at millions of sockets can hold
> cpu for many seconds, if the lookup condition is very narrow.
>
> (eg : ss dst 1.2.3.4 )
>
> Better add a cond_resched() to allow other processes to access
> the cpu.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, thanks Eric.
prev parent reply other threads:[~2016-03-14 23:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-14 22:40 [PATCH net] net: diag: add a scheduling point in inet_diag_dump_icsk() Eric Dumazet
2016-03-14 23:38 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160314.193837.2161977859793491820.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).