From: David Miller <davem@davemloft.net>
To: ben@decadent.org.uk
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] ethtool: Set cmd field in ETHTOOL_GLINKSETTINGS response to wrong nwords
Date: Wed, 16 Mar 2016 20:16:47 -0400 (EDT) [thread overview]
Message-ID: <20160316.201647.156083693171887111.davem@davemloft.net> (raw)
In-Reply-To: <1458171392.31907.39.camel@decadent.org.uk>
From: Ben Hutchings <ben@decadent.org.uk>
Date: Wed, 16 Mar 2016 23:36:32 +0000
> On Wed, 2016-03-16 at 19:26 -0400, David Miller wrote:
>> From: Ben Hutchings <ben@decadent.org.uk>
>> Date: Mon, 14 Mar 2016 01:05:38 +0000
>>
>> > When the ETHTOOL_GLINKSETTINGS implementation finds that userland is
>> > using the wrong number of words of link mode bitmaps (or is trying to
>> > find out the right numbers) it sets the cmd field to 0 in the response
>> > structure.
>> >
>> > This is inconsistent with the implementation of every other ethtool
>> > command, so let's remove that inconsistency before it gets into a
>> > stable release.
>> >
>> > Fixes: 3f1ac7a700d03 ("net: ethtool: add new ETHTOOL_xLINKSETTINGS API")
>> > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
>>
>> Applied and queued up for -stable, thanks Ben.
>
> This doesn't need fixing in any stable release.
My bad I thought it was needed for 4.5-final.
prev parent reply other threads:[~2016-03-17 0:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-14 1:05 [PATCH net-next] ethtool: Set cmd field in ETHTOOL_GLINKSETTINGS response to wrong nwords Ben Hutchings
2016-03-15 19:00 ` david decotigny
2016-03-16 23:26 ` David Miller
2016-03-16 23:36 ` Ben Hutchings
2016-03-17 0:16 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160316.201647.156083693171887111.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ben@decadent.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).