From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
santosh.shilimkar@oracle.com, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next v3 1/2] RDS: TCP: Add sysctl tunables for sndbuf/rcvbuf on rds-tcp socket
Date: Wed, 16 Mar 2016 07:32:11 -0400 [thread overview]
Message-ID: <20160316113211.GC21307@oracle.com> (raw)
In-Reply-To: <56E942F0.90201@stressinduktion.org>
On (03/16/16 12:26), Hannes Frederic Sowa wrote:
>
> My hope was actually that by using the ->data pointer in netns you
> don't need to provide the two functions, just simply use something
> like the following for both cases.
Ok, it would probably be less hacky to do it as you suggest.
> Do I understand it correctly that all connections of a namespace
> will be dropped if you modify those sysctls?
yes. it's unfortunate, but afaict there's no other way to make them
use the new vars.
But as I said in the comments, an admin who goes around creating
this churn is probably doing this very rarely, and for a good
reason, and is fully aware of the cost. So there is some degree
of human control possible.
--Sowmini
next prev parent reply other threads:[~2016-03-16 11:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 18:53 [PATCH net-next v3 0/2] RDS: TCP: tunable socket buffer parameters Sowmini Varadhan
2016-03-15 18:53 ` [PATCH net-next v3 1/2] RDS: TCP: Add sysctl tunables for sndbuf/rcvbuf on rds-tcp socket Sowmini Varadhan
2016-03-15 19:21 ` santosh shilimkar
2016-03-16 10:29 ` Hannes Frederic Sowa
2016-03-16 11:06 ` Sowmini Varadhan
2016-03-16 11:10 ` Sowmini Varadhan
2016-03-16 11:26 ` Hannes Frederic Sowa
2016-03-16 11:32 ` Sowmini Varadhan [this message]
2016-03-15 18:53 ` [PATCH net-next v3 2/2] RDS: TCP: Remove unused constant Sowmini Varadhan
2016-03-15 19:22 ` santosh shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160316113211.GC21307@oracle.com \
--to=sowmini.varadhan@oracle.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
--cc=santosh.shilimkar@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).