From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, blazarus@google.com, ncardwell@google.com
Subject: Re: [PATCH net] tcp/dccp: remove obsolete WARN_ON() in icmp handlers
Date: Thu, 17 Mar 2016 21:07:15 -0400 (EDT) [thread overview]
Message-ID: <20160317.210715.1891529884014626450.davem@davemloft.net> (raw)
In-Reply-To: <1458193935.7353.44.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 16 Mar 2016 22:52:15 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> Now SYN_RECV request sockets are installed in ehash table, an ICMP
> handler can find a request socket while another cpu handles an incoming
> packet transforming this SYN_RECV request socket into an ESTABLISHED
> socket.
>
> We need to remove the now obsolete WARN_ON(req->sk), since req->sk
> is set when a new child is created and added into listener accept queue.
>
> If this race happens, the ICMP will do nothing special.
>
> Fixes: 079096f103fa ("tcp/dccp: install syn_recv requests into ehash table")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: Ben Lazarus <blazarus@google.com>
> Reported-by: Neal Cardwell <ncardwell@google.com>
Applied and queued up for -stable, thanks Eric.
prev parent reply other threads:[~2016-03-18 1:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 5:52 [PATCH net] tcp/dccp: remove obsolete WARN_ON() in icmp handlers Eric Dumazet
2016-03-18 1:07 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160317.210715.1891529884014626450.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=blazarus@google.com \
--cc=eric.dumazet@gmail.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox