[PATCH] qmi_wwan: Added support for Gemalto's Cinterion PHxx WWAN interface

netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH] qmi_wwan: Added support for Gemalto's Cinterion PHxx WWAN interface
@ 2016-03-17 10:07 Schemmel Hans-Christoph
  2016-03-17 16:23 ` Bjørn Mork
       [not found] ` <1978E4F2CF12DD4A899FA7487323EB11010836882A-uHmIn6rc3TL7XpjMj+VyizY6JsNizA6ek7cHwXyjAIw@public.gmane.org>
  0 siblings, 2 replies; 10+ messages in thread
From: Schemmel Hans-Christoph @ 2016-03-17 10:07 UTC (permalink / raw)
  To: bjorn@mork.no, netdev@vger.kernel.org; +Cc: linux-usb@vger.kernel.org

[-- Attachment #1: Type: text/plain, Size: 1265 bytes --]

Added support for Gemalto's Cinterion PHxx WWAN interfaces 
by adding QMI_FIXED_INTF with Cinterion's VID and PID.

PHxx can have:
2 RmNet Interfaces (PID 0x0082) or
1 RmNet + 1 USB Audio interface (PID 0x0083).

Signed-off-by: Hans-Christoph Schemmel <hans-christoph.schemmel@gemalto.com>
---
patch is against linux-4.5
--- linux/drivers/net/usb/qmi_wwan.c.orig	2016-03-14 12:18:07.153497489 +0100
+++ linux/drivers/net/usb/qmi_wwan.c	2016-03-14 12:21:37.722541644 +0100
@@ -881,6 +881,9 @@ static const struct usb_device_id produc
 	{QMI_FIXED_INTF(0x0b3c, 0xc00b, 4)},	/* Olivetti Olicard 500 */
 	{QMI_FIXED_INTF(0x1e2d, 0x0060, 4)},	/* Cinterion PLxx */
 	{QMI_FIXED_INTF(0x1e2d, 0x0053, 4)},	/* Cinterion PHxx,PXxx */
+	{QMI_FIXED_INTF(0x1e2d, 0x0082, 4)},	/* Cinterion PHxx,PXxx (2 RmNet) */
+	{QMI_FIXED_INTF(0x1e2d, 0x0082, 5)},	/* Cinterion PHxx,PXxx (2 RmNet) */
+	{QMI_FIXED_INTF(0x1e2d, 0x0083, 4)},	/* Cinterion PHxx,PXxx (1 RmNet + USB Audio)*/
 	{QMI_FIXED_INTF(0x413c, 0x81a2, 8)},	/* Dell Wireless 5806 Gobi(TM) 4G LTE Mobile Broadband Card */
 	{QMI_FIXED_INTF(0x413c, 0x81a3, 8)},	/* Dell Wireless 5570 HSPA+ (42Mbps) Mobile Broadband Card */
 	{QMI_FIXED_INTF(0x413c, 0x81a4, 8)},	/* Dell Wireless 5570e HSPA+ (42Mbps) Mobile Broadband Card */

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 7229 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] qmi_wwan: Added support for Gemalto's Cinterion PHxx WWAN interface
  2016-03-17 10:07 [PATCH] qmi_wwan: Added support for Gemalto's Cinterion PHxx WWAN interface Schemmel Hans-Christoph
@ 2016-03-17 16:23 ` Bjørn Mork
       [not found] ` <1978E4F2CF12DD4A899FA7487323EB11010836882A-uHmIn6rc3TL7XpjMj+VyizY6JsNizA6ek7cHwXyjAIw@public.gmane.org>
  1 sibling, 0 replies; 10+ messages in thread
From: Bjørn Mork @ 2016-03-17 16:23 UTC (permalink / raw)
  To: Schemmel Hans-Christoph; +Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org

Schemmel Hans-Christoph <Hans-Christoph.Schemmel@gemalto.com> writes:

> Added support for Gemalto's Cinterion PHxx WWAN interfaces 
> by adding QMI_FIXED_INTF with Cinterion's VID and PID.
>
> PHxx can have:
> 2 RmNet Interfaces (PID 0x0082) or
> 1 RmNet + 1 USB Audio interface (PID 0x0083).
>
> Signed-off-by: Hans-Christoph Schemmel <hans-christoph.schemmel@gemalto.com>
> ---
> patch is against linux-4.5
> --- linux/drivers/net/usb/qmi_wwan.c.orig	2016-03-14 12:18:07.153497489 +0100
> +++ linux/drivers/net/usb/qmi_wwan.c	2016-03-14 12:21:37.722541644 +0100
> @@ -881,6 +881,9 @@ static const struct usb_device_id produc
>  	{QMI_FIXED_INTF(0x0b3c, 0xc00b, 4)},	/* Olivetti Olicard 500 */
>  	{QMI_FIXED_INTF(0x1e2d, 0x0060, 4)},	/* Cinterion PLxx */
>  	{QMI_FIXED_INTF(0x1e2d, 0x0053, 4)},	/* Cinterion PHxx,PXxx */
> +	{QMI_FIXED_INTF(0x1e2d, 0x0082, 4)},	/* Cinterion PHxx,PXxx (2 RmNet) */
> +	{QMI_FIXED_INTF(0x1e2d, 0x0082, 5)},	/* Cinterion PHxx,PXxx (2 RmNet) */
> +	{QMI_FIXED_INTF(0x1e2d, 0x0083, 4)},	/* Cinterion PHxx,PXxx (1 RmNet + USB Audio)*/
>  	{QMI_FIXED_INTF(0x413c, 0x81a2, 8)},	/* Dell Wireless 5806 Gobi(TM) 4G LTE Mobile Broadband Card */
>  	{QMI_FIXED_INTF(0x413c, 0x81a3, 8)},	/* Dell Wireless 5570 HSPA+ (42Mbps) Mobile Broadband Card */
>  	{QMI_FIXED_INTF(0x413c, 0x81a4, 8)},	/* Dell Wireless 5570e HSPA+ (42Mbps) Mobile Broadband Card */

Perfect.  Thanks.

Acked-by: Bjørn Mork <bjorn@mork.no>

^ permalink raw reply	[flat|nested] 10+ messages in thread

[parent not found: <1978E4F2CF12DD4A899FA7487323EB11010836882A-uHmIn6rc3TL7XpjMj+VyizY6JsNizA6ek7cHwXyjAIw@public.gmane.org>]

* Re: [PATCH] qmi_wwan: Added support for Gemalto's Cinterion PHxx WWAN interface
       [not found] ` <1978E4F2CF12DD4A899FA7487323EB11010836882A-uHmIn6rc3TL7XpjMj+VyizY6JsNizA6ek7cHwXyjAIw@public.gmane.org>
@ 2016-03-18  1:10   ` David Miller
  0 siblings, 0 replies; 10+ messages in thread
From: David Miller @ 2016-03-18  1:10 UTC (permalink / raw)
  To: Hans-Christoph.Schemmel-av01+Y74gORBDgjK7y7TUQ
  Cc: bjorn-yOkvZcmFvRU, netdev-u79uwXL29TY76Z2rM5mHXA,
	linux-usb-u79uwXL29TY76Z2rM5mHXA

From: Schemmel Hans-Christoph <Hans-Christoph.Schemmel-av01+Y74gORBDgjK7y7TUQ@public.gmane.org>
Date: Thu, 17 Mar 2016 10:07:56 +0000

> Added support for Gemalto's Cinterion PHxx WWAN interfaces 
> by adding QMI_FIXED_INTF with Cinterion's VID and PID.
> 
> PHxx can have:
> 2 RmNet Interfaces (PID 0x0082) or
> 1 RmNet + 1 USB Audio interface (PID 0x0083).
> 
> Signed-off-by: Hans-Christoph Schemmel <hans-christoph.schemmel-av01+Y74gORBDgjK7y7TUQ@public.gmane.org>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH] qmi_wwan: Added support for Gemalto's Cinterion PHxx WWAN interface
@ 2016-03-16  8:31 Schemmel Hans-Christoph
  2016-03-16  8:37 ` Bjørn Mork
  0 siblings, 1 reply; 10+ messages in thread
From: Schemmel Hans-Christoph @ 2016-03-16  8:31 UTC (permalink / raw)
  To: bjorn@mork.no, netdev@vger.kernel.org; +Cc: linux-usb@vger.kernel.org

[-- Attachment #1: Type: text/plain, Size: 1265 bytes --]

Added support for Gemalto's Cinterion PHxx WWAN interfaces 
by adding QMI_FIXED_INTF with Cinterion's VID and PID.

PHxx can have 
2 RmNet Interfaces (PID 0x0082) or
1 RmNet + 1 USB Audio interface (PID 0x0083).

Signed-off-by: Hans-Christoph Schemmel <hans-christoph.schemmel@gemalto.com>
---
patch is against linux-4.5
--- linux/drivers/net/usb/qmi_wwan.c.orig	2016-03-14
12:18:07.153497489 +0100
+++ linux/drivers/net/usb/qmi_wwan.c	2016-03-14 12:21:37.722541644 +0100
@@ -881,6 +881,9 @@ static const struct usb_device_id produc
 	{QMI_FIXED_INTF(0x0b3c, 0xc00b, 4)},	/* Olivetti Olicard 500 */
 	{QMI_FIXED_INTF(0x1e2d, 0x0060, 4)},	/* Cinterion PLxx */
 	{QMI_FIXED_INTF(0x1e2d, 0x0053, 4)},	/* Cinterion PHxx,PXxx */
+	{QMI_FIXED_INTF(0x1e2d, 0x0082, 4)},	/* Cinterion PHxx,PXxx (2
RmNet) */
+	{QMI_FIXED_INTF(0x1e2d, 0x0082, 5)},	/* Cinterion PHxx,PXxx (2
RmNet) */
+	{QMI_FIXED_INTF(0x1e2d, 0x0083, 4)},	/* Cinterion PHxx,PXxx (1
RmNet + USB Audio)*/
 	{QMI_FIXED_INTF(0x413c, 0x81a2, 8)},	/* Dell Wireless 5806
Gobi(TM) 4G LTE Mobile Broadband Card */
 	{QMI_FIXED_INTF(0x413c, 0x81a3, 8)},	/* Dell Wireless 5570 HSPA+
(42Mbps) Mobile Broadband Card */
 	{QMI_FIXED_INTF(0x413c, 0x81a4, 8)},	/* Dell Wireless 5570e HSPA+
(42Mbps) Mobile Broadband Card */

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 7229 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] qmi_wwan: Added support for Gemalto's Cinterion PHxx WWAN interface
  2016-03-16  8:31 Schemmel Hans-Christoph
@ 2016-03-16  8:37 ` Bjørn Mork
  0 siblings, 0 replies; 10+ messages in thread
From: Bjørn Mork @ 2016-03-16  8:37 UTC (permalink / raw)
  To: Schemmel Hans-Christoph; +Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org

Schemmel Hans-Christoph <Hans-Christoph.Schemmel@gemalto.com> writes:

> +	{QMI_FIXED_INTF(0x1e2d, 0x0082, 4)},	/* Cinterion PHxx,PXxx (2
> RmNet) */

That's broken.  Sorry.  You'll have to figure out some way submit this
in a form that can be applied using "git am".

There are some hints in
https://www.kernel.org/doc/Documentation/email-clients.txt



Bjørn

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH] qmi_wwan: Added support for Gemalto's Cinterion PHxx WWAN interface
@ 2016-03-15  9:02 Schemmel Hans-Christoph
  2016-03-15 12:27 ` Bjørn Mork
  0 siblings, 1 reply; 10+ messages in thread
From: Schemmel Hans-Christoph @ 2016-03-15  9:02 UTC (permalink / raw)
  To: bjorn-yOkvZcmFvRU@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
  Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org

Added support for Cinterion's PHxx WWAN interfaces by adding
QMI_FIXED_INTF with Cinterion's VID and PID.

PHxx can have 2 RmNet Interfaces (PID 0x0082)
or 1 RmNet + 1 USB Audio interface (PID 0x0083).

Signed-off-by: Hans-Christoph Schemmel <hans-christoph.schemmel-av01+Y74gORBDgjK7y7TUQ@public.gmane.org>
---
patch is against linux-4.5
--- linux/drivers/net/usb/qmi_wwan.c.orig       2016-03-14 12:18:07.153497489 +0100
+++ linux/drivers/net/usb/qmi_wwan.c    2016-03-14 12:21:37.722541644 +0100
@@ -881,6 +881,9 @@ static const struct usb_device_id produc
        {QMI_FIXED_INTF(0x0b3c, 0xc00b, 4)},    /* Olivetti Olicard 500 */
        {QMI_FIXED_INTF(0x1e2d, 0x0060, 4)},    /* Cinterion PLxx */
        {QMI_FIXED_INTF(0x1e2d, 0x0053, 4)},    /* Cinterion PHxx,PXxx */
+       {QMI_FIXED_INTF(0x1e2d, 0x0082, 4)},    /* Cinterion PHxx,PXxx (2 RmNet) */
+       {QMI_FIXED_INTF(0x1e2d, 0x0082, 5)},    /* Cinterion PHxx,PXxx (2 RmNet) */
+       {QMI_FIXED_INTF(0x1e2d, 0x0083, 4)},    /* Cinterion PHxx,PXxx (1 RmNet + USB Audio)*/
        {QMI_FIXED_INTF(0x413c, 0x81a2, 8)},    /* Dell Wireless 5806 Gobi(TM) 4G LTE Mobile Broadband Card */
        {QMI_FIXED_INTF(0x413c, 0x81a3, 8)},    /* Dell Wireless 5570 HSPA+ (42Mbps) Mobile Broadband Card */
        {QMI_FIXED_INTF(0x413c, 0x81a4, 8)},    /* Dell Wireless 5570e HSPA+ (42Mbps) Mobile Broadband Card */
________________________________
 This message and any attachments are intended solely for the addressees and may contain confidential information. Any unauthorized use or disclosure, either whole or partial, is prohibited.
E-mails are susceptible to alteration. Our company shall not be liable for the message if altered, changed or falsified. If you are not the intended recipient of this message, please delete it and notify the sender.
Although all reasonable efforts have been made to keep this transmission free from viruses, the sender will not be liable for damages caused by a transmitted virus.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] qmi_wwan: Added support for Gemalto's Cinterion PHxx WWAN interface
  2016-03-15  9:02 Schemmel Hans-Christoph
@ 2016-03-15 12:27 ` Bjørn Mork
  2016-03-15 21:52   ` David Miller
  0 siblings, 1 reply; 10+ messages in thread
From: Bjørn Mork @ 2016-03-15 12:27 UTC (permalink / raw)
  To: Schemmel Hans-Christoph; +Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org

Schemmel Hans-Christoph <Hans-Christoph.Schemmel@gemalto.com> writes:

>  If you are not the intended recipient of this message, please delete it and notify the sender.

OK. Deleted.


Bjørn

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] qmi_wwan: Added support for Gemalto's Cinterion PHxx WWAN interface
  2016-03-15 12:27 ` Bjørn Mork
@ 2016-03-15 21:52   ` David Miller
  2016-03-16  7:35     ` Schemmel Hans-Christoph
  0 siblings, 1 reply; 10+ messages in thread
From: David Miller @ 2016-03-15 21:52 UTC (permalink / raw)
  To: bjorn; +Cc: Hans-Christoph.Schemmel, netdev, linux-usb

From: Bjørn Mork <bjorn@mork.no>
Date: Tue, 15 Mar 2016 13:27:03 +0100

> Schemmel Hans-Christoph <Hans-Christoph.Schemmel@gemalto.com> writes:
> 
>>  If you are not the intended recipient of this message, please delete it and notify the sender.
> 
> OK. Deleted.

I've also deleted it and therefore won't look at this patch.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* RE: [PATCH] qmi_wwan: Added support for Gemalto's Cinterion PHxx WWAN interface
  2016-03-15 21:52   ` David Miller
@ 2016-03-16  7:35     ` Schemmel Hans-Christoph
       [not found]       ` <1978E4F2CF12DD4A899FA7487323EB11010836833C-uHmIn6rc3TL7XpjMj+VyizY6JsNizA6ek7cHwXyjAIw@public.gmane.org>
  0 siblings, 1 reply; 10+ messages in thread
From: Schemmel Hans-Christoph @ 2016-03-16  7:35 UTC (permalink / raw)
  To: David Miller, bjorn@mork.no
  Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org

[-- Attachment #1: Type: text/plain, Size: 743 bytes --]

> From: David Miller [mailto:davem@davemloft.net]
> Sent: Dienstag, 15. März 2016 22:52
> 
> From: Bjørn Mork <bjorn@mork.no>
> Date: Tue, 15 Mar 2016 13:27:03 +0100
> 
> > Schemmel Hans-Christoph <Hans-Christoph.Schemmel@gemalto.com>
> writes:
> >
> >>  If you are not the intended recipient of this message, please delete
it and
> notify the sender.
> >
> > OK. Deleted.
> 
> I've also deleted it and therefore won't look at this patch.


Ok, I see. Sorry, the disclaimer is automatically added by companies' mail
server.
If I digital sign the mail it should be send unmodified/without disclaimer.
But there will be the smime.p7s attached to the mail - like in this mail. 

Would it be ok?

Kind regards
Christoph

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 7229 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

[parent not found: <1978E4F2CF12DD4A899FA7487323EB11010836833C-uHmIn6rc3TL7XpjMj+VyizY6JsNizA6ek7cHwXyjAIw@public.gmane.org>]

* RE: [PATCH] qmi_wwan: Added support for Gemalto's Cinterion PHxx WWAN interface
       [not found]       ` <1978E4F2CF12DD4A899FA7487323EB11010836833C-uHmIn6rc3TL7XpjMj+VyizY6JsNizA6ek7cHwXyjAIw@public.gmane.org>
@ 2016-03-16  7:46         ` Bjørn Mork
  0 siblings, 0 replies; 10+ messages in thread
From: Bjørn Mork @ 2016-03-16  7:46 UTC (permalink / raw)
  To: Schemmel Hans-Christoph, David Miller
  Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org



On March 16, 2016 8:35:26 AM CET, Schemmel Hans-Christoph <Hans-Christoph.Schemmel-av01+Y74gORBDgjK7y7TUQ@public.gmane.org> :
>
>If I digital sign the mail it should be send unmodified/without
>disclaimer.
>But there will be the smime.p7s attached to the mail - like in this
>mail. 
>
>Would it be ok?

Fine with me as long as it applies cleanly without having to consult a lawyer :)

Try it and we'll find out. If it doesn't work then please use a private account to submit. You can still set the from and sob to your work email if that is important. 


Bjørn

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2016-03-18  1:10 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-17 10:07 [PATCH] qmi_wwan: Added support for Gemalto's Cinterion PHxx WWAN interface Schemmel Hans-Christoph
2016-03-17 16:23 ` Bjørn Mork
     [not found] ` <1978E4F2CF12DD4A899FA7487323EB11010836882A-uHmIn6rc3TL7XpjMj+VyizY6JsNizA6ek7cHwXyjAIw@public.gmane.org>
2016-03-18  1:10   ` David Miller
  -- strict thread matches above, loose matches on Subject: below --
2016-03-16  8:31 Schemmel Hans-Christoph
2016-03-16  8:37 ` Bjørn Mork
2016-03-15  9:02 Schemmel Hans-Christoph
2016-03-15 12:27 ` Bjørn Mork
2016-03-15 21:52   ` David Miller
2016-03-16  7:35     ` Schemmel Hans-Christoph
     [not found]       ` <1978E4F2CF12DD4A899FA7487323EB11010836833C-uHmIn6rc3TL7XpjMj+VyizY6JsNizA6ek7cHwXyjAIw@public.gmane.org>
2016-03-16  7:46         ` Bjørn Mork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).