From: Leon Romanovsky <leon@leon.nu>
To: Jiri Pirko <jiri@resnulli.us>
Cc: oulijun <oulijun@huawei.com>,
dledford@redhat.com, sean.hefty@intel.com,
hal.rosenstock@gmail.com, davem@davemloft.net,
jeffrey.t.kirsher@intel.com, jiri@mellanox.com,
ogerlitz@mellanox.com, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
gongyangming@huawei.com, xiaokun@huawei.com,
tangchaofei@huawei.com, haifeng.wei@huawei.com,
yisen.zhuang@huawei.com, yankejian@huawei.com,
lisheng011@huawei.com, charles.chenxin@huawei.com,
linuxarm@huawei.com
Subject: Re: [PATCH 1/3] infiniband: IB/hns: add Hisilicon RoCE support
Date: Thu, 17 Mar 2016 08:43:59 +0200 [thread overview]
Message-ID: <20160317064359.GA25216@leon.nu> (raw)
In-Reply-To: <20160316103638.GB2254@nanopsycho.orion>
On Wed, Mar 16, 2016 at 11:36:38AM +0100, Jiri Pirko wrote:
> >so, I continue to have it.
>
> I will continue to bash on your odd codingstyle. Please fix it!
Jiri,
Checkpatch errors is an easiest issue with this patch.
It is full of functions without use, unconnected macros and
if you replace "hsi" to name of other well known driver, you will get
same code :).
They need to redesign the whole driver before resubmission.
Thanks.
next prev parent reply other threads:[~2016-03-17 6:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 10:37 [PATCH 0/3] infiniband: IB/hns: Hisilicon RoCE support Lijun Ou
2016-03-11 10:37 ` [PATCH 1/3] infiniband: IB/hns: add " Lijun Ou
[not found] ` <1457692631-9290-2-git-send-email-oulijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-03-11 10:42 ` Jiri Pirko
[not found] ` <20160311104239.GD3931-6KJVSR23iU488b5SBfVpbw@public.gmane.org>
2016-03-16 10:23 ` oulijun
[not found] ` <56E9340E.3040207-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-03-16 10:36 ` Jiri Pirko
2016-03-17 6:43 ` Leon Romanovsky [this message]
2016-03-19 11:11 ` oulijun
2016-03-12 10:39 ` Leon Romanovsky
[not found] ` <20160312103940.GA15703-2ukJVAZIZ/Y@public.gmane.org>
2016-03-16 10:26 ` oulijun
2016-03-11 10:37 ` [PATCH 2/3] net: hns: " Lijun Ou
2016-03-12 10:43 ` Leon Romanovsky
[not found] ` <20160312104301.GB15703-2ukJVAZIZ/Y@public.gmane.org>
2016-03-14 1:12 ` Yankejian (Hackim Yim)
[not found] ` <56E60FFC.3000007-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-03-14 6:49 ` Leon Romanovsky
2016-03-19 11:17 ` oulijun
[not found] ` <1457692631-9290-1-git-send-email-oulijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-03-11 10:37 ` [PATCH 3/3] infiniband: IB/hns: add Hisilicon RoCE support with bindings Lijun Ou
[not found] ` <1457692631-9290-4-git-send-email-oulijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-03-11 13:39 ` Sergei Shtylyov
[not found] ` <56E2CA90.9020401-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2016-03-19 11:14 ` oulijun
2016-03-12 10:20 ` [PATCH 0/3] infiniband: IB/hns: Hisilicon RoCE support Leon Romanovsky
2016-03-19 11:13 ` oulijun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160317064359.GA25216@leon.nu \
--to=leon@leon.nu \
--cc=charles.chenxin@huawei.com \
--cc=davem@davemloft.net \
--cc=dledford@redhat.com \
--cc=gongyangming@huawei.com \
--cc=haifeng.wei@huawei.com \
--cc=hal.rosenstock@gmail.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jiri@mellanox.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lisheng011@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=oulijun@huawei.com \
--cc=sean.hefty@intel.com \
--cc=tangchaofei@huawei.com \
--cc=xiaokun@huawei.com \
--cc=yankejian@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).