Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: dan.carpenter@oracle.com
Cc: richard.rojfors@pelagicore.com, netdev@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [patch] ethernet: micrel: fix some error codes
Date: Fri, 18 Mar 2016 19:40:47 -0400 (EDT)	[thread overview]
Message-ID: <20160318.194047.1657460162512006177.davem@davemloft.net> (raw)
In-Reply-To: <20160316074510.GF12860@mwanda>

From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 16 Mar 2016 10:45:10 +0300

> There were two issues here:
> 1) dma_mapping_error() return true/false but we want to return -ENOMEM
> 2) If dmaengine_prep_slave_sg() failed then "err" wasn't set but
>    presumably that should be -ENOMEM as well.
> 
> I changed the success path to "return 0;" instead of "return ret;" for
> clarity.
> 
> Fixes: 94fe8c683cea ('ks8842: Support DMA when accessed via timberdale')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied.

      reply	other threads:[~2016-03-18 23:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-16  7:45 [patch] ethernet: micrel: fix some error codes Dan Carpenter
2016-03-18 23:40 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160318.194047.1657460162512006177.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=richard.rojfors@pelagicore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox