From: David Miller <davem@davemloft.net>
To: ddecotig@gmail.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
nikolay@cumulusnetworks.com, mst@redhat.com, ben@decadent.org.uk,
jeffrey.t.kirsher@intel.com, decot@googlers.com,
nicolas.dichtel@6wind.com, andrew@lunn.ch, hadarh@mellanox.com,
ecree@solarflare.com, john.r.fastabend@intel.com,
herbert@gondor.apana.org.au, tgraf@suug.ch, daniel@iogearbox.net,
chamaken@gmail.com, fw@strlen.de, dh.herrmann@gmail.com
Subject: Re: [PATCH v1 0/2] basic ioctl support for netlink sockets
Date: Sun, 20 Mar 2016 13:31:22 -0400 (EDT) [thread overview]
Message-ID: <20160320.133122.908035685889835834.davem@davemloft.net> (raw)
In-Reply-To: <1458259436-85275-1-git-send-email-ddecotig@gmail.com>
From: David Decotigny <ddecotig@gmail.com>
Date: Thu, 17 Mar 2016 17:03:54 -0700
> This removes the requirement that ethtool be tied to the support
> of a specific L3 protocol, also updates a comment.
You're adding an ioctl handler to netlink sockets, and it is not
at all apparent to me how this influences ethtool handling at all.
Therefore you have to explain this here and in your commit message.
next prev parent reply other threads:[~2016-03-20 17:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 0:03 [PATCH v1 0/2] basic ioctl support for netlink sockets David Decotigny
2016-03-18 0:03 ` [PATCH v1 1/2] ethtool: minor doc update David Decotigny
2016-03-18 0:29 ` Ben Hutchings
2016-03-18 0:03 ` [PATCH v1 2/2] netlink: add support for NIC driver ioctls David Decotigny
2016-03-20 17:31 ` David Miller [this message]
2016-03-21 17:43 ` [PATCH v1 0/2] basic ioctl support for netlink sockets David Decotigny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160320.133122.908035685889835834.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=ben@decadent.org.uk \
--cc=chamaken@gmail.com \
--cc=daniel@iogearbox.net \
--cc=ddecotig@gmail.com \
--cc=decot@googlers.com \
--cc=dh.herrmann@gmail.com \
--cc=ecree@solarflare.com \
--cc=fw@strlen.de \
--cc=hadarh@mellanox.com \
--cc=herbert@gondor.apana.org.au \
--cc=jeffrey.t.kirsher@intel.com \
--cc=john.r.fastabend@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=nikolay@cumulusnetworks.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).