netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Jeff Layton <jlayton@poochiereds.net>,
	"David S. Miller" <davem@davemloft.net>,
	Trond Myklebust <trond.myklebust@primarydata.com>,
	Anna Schumaker <anna.schumaker@netapp.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-nfs@vger.kernel.org,
	Amitoj Kaur Chawla <amitoj1606@gmail.com>,
	kernel-team@fb.com, Johannes Weiner <hannes@cmpxchg.org>,
	Johannes Berg <johannes@sipsolutions.net>,
	Eva Rachel Retuya <eraretuya@gmail.com>,
	Bhaktipriya Shridhar <bhaktipriya96@gmail.com>,
	linux-wireless@vger.kernel.org
Subject: Re: [RFD] workqueue: WQ_MEM_RECLAIM usage in network drivers
Date: Sun, 20 Mar 2016 14:55:07 -0400	[thread overview]
Message-ID: <20160320185507.GT20028@mtj.duckdns.org> (raw)
In-Reply-To: <20160318212405.GA5192@fieldses.org>

Hello,

On Fri, Mar 18, 2016 at 05:24:05PM -0400, J. Bruce Fields wrote:
> > But does that actually work?  It's pointless to add WQ_MEM_RECLAIM to
> > workqueues unless all other things are also guaranteed to make forward
> > progress regardless of memory pressure.
> 
> It's supposed to work.
> 
> Also note there was a bunch of work done to allow swap on NFS: see
> a564b8f0 "nfs: enable swap on NFS".

Alright, WQ_MEM_RECLAIM for ethernet devices, then.

> I use NFS mounts over wifi at home.  I may just be odd.  I seem to
> recall some bug reports about suspend vs. NFS--were those also on
> laptops using NFS?
> 
> I wonder if home media centers might do writes over wifi to network
> storage?
> 
> Googling for "nfs wifi" turns up lots of individuals doing this.
> 
> My first impulse is to say that it's probably not perfect but that we
> shouldn't make it worse.

If everything else is working, I'd be happy to throw in WQ_MEM_RECLAIM
but I really don't want to add it if it doesn't actually achieve the
goal.  Can a wireless person chime in here?

Thanks.

-- 
tejun

  reply	other threads:[~2016-03-20 18:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-17 16:45 [RFD] workqueue: WQ_MEM_RECLAIM usage in network drivers Tejun Heo
     [not found] ` <20160317164546.GT21104-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2016-03-18  1:32   ` Jeff Layton
     [not found]     ` <20160317213216.731d1fcc-08S845evdOaAjSkqwZiSMmfYqLom42DlXqFh9Ls21Oc@public.gmane.org>
2016-03-18 20:46       ` Tejun Heo
     [not found]         ` <20160318204623.GM20028-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2016-03-18 21:24           ` J. Bruce Fields
2016-03-20 18:55             ` Tejun Heo [this message]
     [not found]               ` <20160320185507.GT20028-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2016-03-24 14:22                 ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160320185507.GT20028@mtj.duckdns.org \
    --to=tj@kernel.org \
    --cc=amitoj1606@gmail.com \
    --cc=anna.schumaker@netapp.com \
    --cc=bfields@fieldses.org \
    --cc=bhaktipriya96@gmail.com \
    --cc=davem@davemloft.net \
    --cc=eraretuya@gmail.com \
    --cc=hannes@cmpxchg.org \
    --cc=jlayton@poochiereds.net \
    --cc=johannes@sipsolutions.net \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=trond.myklebust@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).