From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] vxlan: fix sparse warnings Date: Mon, 21 Mar 2016 13:30:24 -0400 (EDT) Message-ID: <20160321.133024.783333130148685527.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, fengguang.wu@intel.com To: jbenc@redhat.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:48719 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756703AbcCURaZ (ORCPT ); Mon, 21 Mar 2016 13:30:25 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Jiri Benc Date: Mon, 21 Mar 2016 17:39:18 +0100 > Sparse reports false positives for the header manipulation inlines. Annotate > them correctly. > > Tested by sparse on a little endian and big endian machine. > > Fixes: 54bfd872bf16d ("vxlan: keep flags and vni in network byte order") > Reported-by: kbuild test robot > Signed-off-by: Jiri Benc Applied, thanks Jiri. > As a side note, I tried to simplify all of these functions by using nested > be32_to_cpu(cpu_to_be32()) calls but GCC seems not to be clever enough to > optimize the byteswaps out. Ok, thanks for the note, thanks again.