From: David Miller <davem@redhat.com>
To: sergei.shtylyov@cogentembedded.com
Cc: netdev@vger.kernel.org, nicolas.ferre@atmel.com
Subject: Re: [PATCH] macb: fix PHY reset
Date: Tue, 22 Mar 2016 16:07:38 -0400 (EDT) [thread overview]
Message-ID: <20160322.160738.145737905213296810.davem@redhat.com> (raw)
In-Reply-To: <56F19E2D.8000700@cogentembedded.com>
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Tue, 22 Mar 2016 22:34:05 +0300
> On 03/22/2016 10:27 PM, Sergei Shtylyov wrote:
>
>> The driver calls gpiod_set_value() with GPIOD_OUT_* instead of 0 and
>> 1, as
>> a result the PHY isn't really put back into reset state in
>> macb_remove().
>> Moreover, the driver assumes that something else has set the GPIO
>> direction
>> to output, so if it has not, the PHY wouldn't be taken out of reset in
>
> s/wouldn't/may not/, sorry. Do I need to resend?
No need, I fixed it up by hand.
Applied, thanks.
next prev parent reply other threads:[~2016-03-22 20:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 19:27 [PATCH] macb: fix PHY reset Sergei Shtylyov
2016-03-22 19:34 ` Sergei Shtylyov
2016-03-22 20:07 ` David Miller [this message]
2016-03-22 21:04 ` Sergei Shtylyov
2016-03-22 21:33 ` Sergei Shtylyov
2016-03-23 8:54 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160322.160738.145737905213296810.davem@redhat.com \
--to=davem@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).