From: David Miller <davem@davemloft.net>
To: aduyck@mirantis.com
Cc: tom@herbertland.com, kernel-team@fb.com,
alexander.duyck@gmail.com, netdev@vger.kernel.org
Subject: Re: [net PATCH] net: Reset encap_level to avoid resetting features on inner IP headers
Date: Wed, 23 Mar 2016 14:19:44 -0400 (EDT) [thread overview]
Message-ID: <20160323.141944.223192963031809374.davem@davemloft.net> (raw)
In-Reply-To: <20160322231732.13054.71337.stgit@localhost.localdomain>
From: Alexander Duyck <aduyck@mirantis.com>
Date: Tue, 22 Mar 2016 16:18:07 -0700
> This patch corrects an oversight in which we were allowing the encap_level
> value to pass from the outer headers to the inner headers. As a result we
> were incorrectly identifying UDP or GRE tunnels as also making use of ipip
> or sit when the second header actually represented a tunnel encapsulated in
> either a UDP or GRE tunnel which already had the features masked.
>
> Fixes: 76443456227097179c1482 ("net: Move GSO csum into SKB_GSO_CB")
> Reported-by: Tom Herbert <tom@herbertland.com>
> Signed-off-by: Alexander Duyck <aduyck@mirantis.com>
Applied, thanks.
prev parent reply other threads:[~2016-03-23 18:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 23:18 [net PATCH] net: Reset encap_level to avoid resetting features on inner IP headers Alexander Duyck
2016-03-23 17:25 ` Tom Herbert
2016-03-23 18:19 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160323.141944.223192963031809374.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aduyck@mirantis.com \
--cc=alexander.duyck@gmail.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).