From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: herbert@gondor.apana.org.au, subashab@codeaurora.org,
steffen.klassert@secunet.com, netdev@vger.kernel.org,
jeromes@codeaurora.org
Subject: Re: [PATCH net v2] xfrm: Fix crash observed during device unregistration and decryption
Date: Wed, 23 Mar 2016 22:08:20 -0400 (EDT) [thread overview]
Message-ID: <20160323.220820.1513725139701314911.davem@davemloft.net> (raw)
In-Reply-To: <1458783597.10868.60.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 23 Mar 2016 18:39:57 -0700
> On Thu, 2016-03-24 at 08:45 +0800, Herbert Xu wrote:
>> On Wed, Mar 23, 2016 at 10:29:25AM -0700, Eric Dumazet wrote:
>> >
>> > OK, but before calling netif_rx() are we properly testing dev->flags
>> > IFF_UP status ?
>> >
>> > Otherwise, we still allow packets being queued after flush_backlog() had
>> > been called.
>>
>> That's the first thing enqueue_to_backlog tests.
>>
>> Cheers,
>
> Seems to be very recent stuff ( commit
> e9e4dd3267d0c5234c5c0f47440456b10875dec9 in linux-4.2)
>
> In the old days the test was done in callers, since in most cases NIC
> drivers do not need it.
>
> Lets make sure this was backported to all stable trees.
>
> And then we probably can cleanup some callers as well.
Anyways this patch needs to be redone because it is corrupted by the
submitter's email client.
I'll queue it up and make sure e9e4dd3267d0c5234c5c0f47440456b10875dec9
ends up in -stable where needed.
Thanks.
prev parent reply other threads:[~2016-03-24 2:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 0:29 [PATCH net v2] xfrm: Fix crash observed during device unregistration and decryption Subash Abhinov Kasiviswanathan
2016-03-23 12:50 ` Steffen Klassert
2016-03-23 13:25 ` Eric Dumazet
2016-03-23 13:29 ` Herbert Xu
2016-03-23 17:29 ` Eric Dumazet
2016-03-24 0:45 ` Herbert Xu
2016-03-24 1:39 ` Eric Dumazet
2016-03-24 2:08 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160323.220820.1513725139701314911.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=jeromes@codeaurora.org \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=subashab@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).