From: Andrew Lunn <andrew@lunn.ch>
To: Vishal Thanki <vishalthanki@gmail.com>
Cc: f.fainelli@gmail.com, ujhelyi.m@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH 0/3] Control ethernet PHY LEDs via LED subsystem
Date: Wed, 23 Mar 2016 19:50:06 +0100 [thread overview]
Message-ID: <20160323185006.GL5250@lunn.ch> (raw)
In-Reply-To: <1458755500-15571-1-git-send-email-vishalthanki@gmail.com>
On Wed, Mar 23, 2016 at 06:51:37PM +0100, Vishal Thanki wrote:
> Hi all,
>
> Based on suggestions from Andrew and Florian, I have made some changes
> to expose the ethernet PHY LEDs using kernel LED subsystem. The following
> ALPHA patchset introduces two new LED triggers:
>
> 1) <phydev>-eth-phy-link:
> To monitor the PHY Link status
>
> 2) <phydev>-eth-phy-activity:
> To monitor the PHY activity status. This trigger may still some more work
> because as of now it just takes decision to set the trigger based on
> PHY state machine and triggers the blink_set with delay_on and delay_off
> parameters set to 0.
My suggestion was that the hardware needs to control the LEDs. You
have software doing it. You might be able to do this with the PHY
state machine for link. But activity is never going to be accepted if
software control.
The LED trigger attached to an LED should be used to configure the
hardware to drive the LED as wanted.
The exception to this is when there is no trigger attached, and the
brightness can set the on/off state, if the hardware supports this.
Andrew
next prev parent reply other threads:[~2016-03-23 18:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 17:51 [PATCH 0/3] Control ethernet PHY LEDs via LED subsystem Vishal Thanki
2016-03-23 17:51 ` [PATCH 1/3] net: phy: Add ethernet PHY LED triggers Vishal Thanki
2016-03-23 17:51 ` [PATCH 2/3] net: phy: at8030: Expose the Link and Activity LEDs Vishal Thanki
2016-03-23 18:56 ` Andrew Lunn
2016-03-23 17:51 ` [PATCH 3/3] led: at8030: Add LED driver for AT8030 ethernet PHY Vishal Thanki
2016-03-23 18:52 ` Andrew Lunn
2016-03-23 18:50 ` Andrew Lunn [this message]
2016-03-23 20:24 ` [PATCH 0/3] Control ethernet PHY LEDs via LED subsystem Vishal Thanki
2016-03-23 21:10 ` Andrew Lunn
2016-03-23 21:24 ` Vishal Thanki
2016-03-24 13:29 ` Andrew Lunn
2016-03-24 17:35 ` Vishal Thanki
2016-03-24 18:50 ` Andrew Lunn
2016-03-28 15:43 ` Stephen Hemminger
2016-03-28 16:10 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160323185006.GL5250@lunn.ch \
--to=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ujhelyi.m@gmail.com \
--cc=vishalthanki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).