From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, lorenzo@google.com
Subject: Re: [PATCH net] inet: add proper locking in __inet{6}_lookup()
Date: Mon, 28 Mar 2016 11:27:10 -0400 (EDT) [thread overview]
Message-ID: <20160328.112710.2279688094912005224.davem@davemloft.net> (raw)
In-Reply-To: <1459175035.6473.92.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 28 Mar 2016 07:23:55 -0700
> On Mon, 2016-03-28 at 07:10 -0700, Eric Dumazet wrote:
>> On Mon, 2016-03-28 at 06:29 -0700, Eric Dumazet wrote:
>>
>> > Sure, but the caller changed quite a lot in all stable versions.
>> >
>> > I took the easiest path for stable maintainers, and was planing to
>> > implement a better way in net-next.
>>
>> I misread your suggestion David, I send a V2 shortly.
>>
>
> Actually, I'll wait for net-next opening.
>
> My brain farted while working on the 'non refcounted TCP listener'
> because __inet_lookup_listener() will really need to be called from
> enclosed rcu_read_lock(), and for a reason I though net tree had a bug.
>
> The local_bh_disable()/local_bh_enable() removal can certainly wait
> net-next.
>
> Sorry for the confusion.
Ok, I'll mark this patch as deferred then.
Thanks Eric.
prev parent reply other threads:[~2016-03-28 15:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-25 22:15 [PATCH net] inet: add proper locking in __inet{6}_lookup() Eric Dumazet
2016-03-28 2:32 ` David Miller
2016-03-28 13:29 ` Eric Dumazet
2016-03-28 14:10 ` Eric Dumazet
2016-03-28 14:23 ` Eric Dumazet
2016-03-28 15:27 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160328.112710.2279688094912005224.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=lorenzo@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).