* [PATCH] openvswitch: Use proper buffer size in nla_memcpy
@ 2016-03-28 10:08 Haishuang Yan
2016-03-28 15:39 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Haishuang Yan @ 2016-03-28 10:08 UTC (permalink / raw)
To: David S. Miller, Pravin Shelar; +Cc: netdev, linux-kernel, dev, Haishuang Yan
For the input parameter count, it's better to use the size
of destination buffer size, as nla_memcpy would take into
account the length of the source netlink attribute when
a data is copied from an attribute.
Signed-off-by: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
---
net/openvswitch/conntrack.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/openvswitch/conntrack.c b/net/openvswitch/conntrack.c
index dc5eb29..f8a8d43 100644
--- a/net/openvswitch/conntrack.c
+++ b/net/openvswitch/conntrack.c
@@ -968,7 +968,8 @@ static int parse_nat(const struct nlattr *attr,
break;
case OVS_NAT_ATTR_IP_MIN:
- nla_memcpy(&info->range.min_addr, a, nla_len(a));
+ nla_memcpy(&info->range.min_addr, a,
+ sizeof(info->range.min_addr));
info->range.flags |= NF_NAT_RANGE_MAP_IPS;
break;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] openvswitch: Use proper buffer size in nla_memcpy
2016-03-28 10:08 [PATCH] openvswitch: Use proper buffer size in nla_memcpy Haishuang Yan
@ 2016-03-28 15:39 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-03-28 15:39 UTC (permalink / raw)
To: yanhaishuang; +Cc: pshelar, netdev, linux-kernel, dev
From: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
Date: Mon, 28 Mar 2016 18:08:59 +0800
> For the input parameter count, it's better to use the size
> of destination buffer size, as nla_memcpy would take into
> account the length of the source netlink attribute when
> a data is copied from an attribute.
>
> Signed-off-by: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-28 15:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-28 10:08 [PATCH] openvswitch: Use proper buffer size in nla_memcpy Haishuang Yan
2016-03-28 15:39 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).