From: Stephen Hemminger <stephen@networkplumber.org>
To: Vishal Thanki <vishalthanki@gmail.com>
Cc: andrew@lunn.ch, f.fainelli@gmail.com, ujhelyi.m@gmail.com,
netdev@vger.kernel.org
Subject: Re: [PATCH 0/3] Control ethernet PHY LEDs via LED subsystem
Date: Mon, 28 Mar 2016 08:43:35 -0700 [thread overview]
Message-ID: <20160328084335.2b631e99@xeon-e3> (raw)
In-Reply-To: <1458755500-15571-1-git-send-email-vishalthanki@gmail.com>
On Wed, 23 Mar 2016 18:51:37 +0100
Vishal Thanki <vishalthanki@gmail.com> wrote:
> Hi all,
>
> Based on suggestions from Andrew and Florian, I have made some changes
> to expose the ethernet PHY LEDs using kernel LED subsystem. The following
> ALPHA patchset introduces two new LED triggers:
>
> 1) <phydev>-eth-phy-link:
> To monitor the PHY Link status
>
> 2) <phydev>-eth-phy-activity:
> To monitor the PHY activity status. This trigger may still some more work
> because as of now it just takes decision to set the trigger based on
> PHY state machine and triggers the blink_set with delay_on and delay_off
> parameters set to 0.
>
> Please provide the review comments so that I can work on this patchset to
> make it complete.
>
> Thanks,
> Vishal
>
> Vishal Thanki (3):
> net: phy: Add ethernet PHY LED triggers
> net: phy: at8030: Expose the Link and Activity LEDs
> led: at8030: Add LED driver for AT8030 ethernet PHY
>
> drivers/leds/Kconfig | 7 ++
> drivers/leds/Makefile | 1 +
> drivers/leds/leds-at803x.c | 158 +++++++++++++++++++++++++++++++++++++++++++
> drivers/net/phy/Kconfig | 7 ++
> drivers/net/phy/Makefile | 1 +
> drivers/net/phy/at803x.c | 55 ++++++++++++++-
> drivers/net/phy/phy.c | 20 +++++-
> drivers/net/phy/phy_device.c | 4 ++
> drivers/net/phy/phy_led.c | 70 +++++++++++++++++++
> drivers/net/phy/phy_led.h | 37 ++++++++++
> include/linux/leds.h | 1 +
> include/linux/phy.h | 6 ++
> include/linux/phy/at803x.h | 45 ++++++++++++
> 13 files changed, 409 insertions(+), 3 deletions(-)
> create mode 100644 drivers/leds/leds-at803x.c
> create mode 100644 drivers/net/phy/phy_led.c
> create mode 100644 drivers/net/phy/phy_led.h
> create mode 100644 include/linux/phy/at803x.h
>
There already is LED control via ethtool.
It is more important that the existing API (ethtool) still work.
next prev parent reply other threads:[~2016-03-28 15:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 17:51 [PATCH 0/3] Control ethernet PHY LEDs via LED subsystem Vishal Thanki
2016-03-23 17:51 ` [PATCH 1/3] net: phy: Add ethernet PHY LED triggers Vishal Thanki
2016-03-23 17:51 ` [PATCH 2/3] net: phy: at8030: Expose the Link and Activity LEDs Vishal Thanki
2016-03-23 18:56 ` Andrew Lunn
2016-03-23 17:51 ` [PATCH 3/3] led: at8030: Add LED driver for AT8030 ethernet PHY Vishal Thanki
2016-03-23 18:52 ` Andrew Lunn
2016-03-23 18:50 ` [PATCH 0/3] Control ethernet PHY LEDs via LED subsystem Andrew Lunn
2016-03-23 20:24 ` Vishal Thanki
2016-03-23 21:10 ` Andrew Lunn
2016-03-23 21:24 ` Vishal Thanki
2016-03-24 13:29 ` Andrew Lunn
2016-03-24 17:35 ` Vishal Thanki
2016-03-24 18:50 ` Andrew Lunn
2016-03-28 15:43 ` Stephen Hemminger [this message]
2016-03-28 16:10 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160328084335.2b631e99@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ujhelyi.m@gmail.com \
--cc=vishalthanki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).