From: David Miller <davem@davemloft.net>
To: tom@herbertland.com
Cc: aduyck@mirantis.com, alexander.duyck@gmail.com, jesse@kernel.org,
netdev@vger.kernel.org
Subject: Re: [net PATCH] gro: Allow tunnel stacking in the case of FOU/GUE
Date: Tue, 29 Mar 2016 17:03:48 -0400 (EDT) [thread overview]
Message-ID: <20160329.170348.883731618823989561.davem@davemloft.net> (raw)
In-Reply-To: <CALx6S37GPMUuhgiWRH+40314x8eKnCWA-zZkvUmsTqf3_AFOhw@mail.gmail.com>
From: Tom Herbert <tom@herbertland.com>
Date: Mon, 28 Mar 2016 21:51:17 -0700
> No, but I do expect that you support code that is already there. There
> was apparently zero testing done on the original patch and it caused
> one very obvious regression. So how can we have any confidence
> whatsoever that this patch doesn't break other things? Furthermore,
> with all these claims of bugs I still don't see that _anyone_ has
> taken the time to reproduce any issue and show that this patch
> materially fixes any thing. I seriously don't understand how basic
> testing could be such a challenge.
>
> Anyway, what I expect is moot. It's up to davem to decide what to do
> with this...
You being upset with a lack of testing is one issue, and is
legitimate.
But the fact that we can't support, and never could support, more than
one network header at a time except in a very special case for GRO
is very real. And you must acknowledge that this was a very shaky
foundation upon which to erect the kinds of things you expect to work.
next prev parent reply other threads:[~2016-03-29 21:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-28 23:58 [net PATCH] gro: Allow tunnel stacking in the case of FOU/GUE Alexander Duyck
2016-03-29 1:00 ` Tom Herbert
2016-03-29 1:24 ` Tom Herbert
2016-03-29 1:54 ` Jesse Gross
2016-03-29 3:17 ` Tom Herbert
2016-03-29 3:27 ` Alexander Duyck
2016-03-29 4:01 ` Tom Herbert
2016-03-29 4:15 ` Alex Duyck
2016-03-29 4:51 ` Tom Herbert
2016-03-29 21:03 ` David Miller [this message]
2016-03-29 2:54 ` Jesse Gross
2016-03-29 21:13 ` Tom Herbert
2016-03-29 21:26 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160329.170348.883731618823989561.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aduyck@mirantis.com \
--cc=alexander.duyck@gmail.com \
--cc=jesse@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox