Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: ezequiel@vanguardiasur.com.ar
Cc: thomas.petazzoni@free-electrons.com, netdev@vger.kernel.org
Subject: Re: [PATCH] ethernet: mvneta: Support netpoll
Date: Tue, 29 Mar 2016 23:09:30 -0400 (EDT)	[thread overview]
Message-ID: <20160329.230930.1234182429605936870.davem@davemloft.net> (raw)
In-Reply-To: <1459197678-12022-1-git-send-email-ezequiel@vanguardiasur.com.ar>

From: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Date: Mon, 28 Mar 2016 17:41:18 -0300

> +/* Polled functionality used by netconsole and others in non interrupt mode */
> +static void mvneta_poll_controller(struct net_device *dev)
> +{
> +	struct mvneta_port *pp = netdev_priv(dev);
> +
> +	on_each_cpu(mvneta_percpu_poll_controller, pp, false);
> +}

This doesn't work.

netpoll may be invoked from any context whatsoever, even hardware
interrupt handlers or contexts where cpu interrupts are disabled.

smp_call_function() and thus on_each_cpu() may not be called with
disabled interrupts or from a hardware interrupt handler or from
a bottom half handler, all of which are valid situations where
netpoll may occur since printk's can occur anywhere.

  reply	other threads:[~2016-03-30  3:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-28 20:41 [PATCH] ethernet: mvneta: Support netpoll Ezequiel Garcia
2016-03-30  3:09 ` David Miller [this message]
2016-03-30  4:59   ` Ezequiel Garcia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160329.230930.1234182429605936870.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=ezequiel@vanguardiasur.com.ar \
    --cc=netdev@vger.kernel.org \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox