From: Stephen Hemminger <stephen@networkplumber.org>
To: Yuchung Cheng <ycheng@google.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
Matt Mathis <mattmathis@google.com>,
Neal Cardwell <ncardwell@google.com>,
Soheil Hassas Yeganeh <soheil@google.com>
Subject: Re: [PATCH net-next] tcp: remove cwnd moderation after recovery
Date: Tue, 29 Mar 2016 17:35:45 -0700 [thread overview]
Message-ID: <20160329173545.5fe0ae8b@xeon-e3> (raw)
In-Reply-To: <1459296952-12214-1-git-send-email-ycheng@google.com>
On Tue, 29 Mar 2016 17:15:52 -0700
Yuchung Cheng <ycheng@google.com> wrote:
> For non-SACK connections, cwnd is lowered to inflight plus 3 packets
> when the recovery ends. This is an optional feature in the NewReno
> RFC 2582 to reduce the potential burst when cwnd is "re-opened"
> after recovery and inflight is low.
>
> This feature is questionably effective because of PRR: when
> the recovery ends (i.e., snd_una == high_seq) NewReno holds the
> CA_Recovery state for another round trip to prevent false fast
> retransmits. But if the inflight is low, PRR will overwrite the
> moderated cwnd in tcp_cwnd_reduction() later.
>
> On the other hand, if the recovery ends because the sender
> detects the losses were spurious (e.g., reordering). This feature
> unconditionally lowers a reverted cwnd even though nothing
> was lost.
>
> By principle loss recovery module should not update cwnd. Further
> pacing is much more effective to reduce burst. Hence this patch
> removes the cwnd moderation feature.
>
> Signed-off-by: Matt Mathis <mattmathis@google.com>
> Signed-off-by: Neal Cardwell <ncardwell@google.com>
> Signed-off-by: Soheil Hassas Yeganeh <soheil@google.com>
I have a concern that this might break Linux builtin protection
against hostile receiver sending bogus ACK's. Remember Linux is
different than NewReno. You are changing something that has existed for
a long long time.
next prev parent reply other threads:[~2016-03-30 0:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 0:15 [PATCH net-next] tcp: remove cwnd moderation after recovery Yuchung Cheng
2016-03-30 0:35 ` Stephen Hemminger [this message]
2016-03-30 20:20 ` Yuchung Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160329173545.5fe0ae8b@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=mattmathis@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=soheil@google.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox