From: David Miller <davem@davemloft.net>
To: aduyck@mirantis.com
Cc: jesse@kernel.org, netdev@vger.kernel.org,
alexander.duyck@gmail.com, tom@herbertland.com
Subject: Re: [net PATCH v2] gro: Allow tunnel stacking in the case of FOU/GUE
Date: Wed, 30 Mar 2016 16:03:20 -0400 (EDT) [thread overview]
Message-ID: <20160330.160320.1141897932138398381.davem@davemloft.net> (raw)
In-Reply-To: <20160329215226.12478.3696.stgit@localhost.localdomain>
From: Alexander Duyck <aduyck@mirantis.com>
Date: Tue, 29 Mar 2016 14:55:22 -0700
> This patch should fix the issues seen with a recent fix to prevent
> tunnel-in-tunnel frames from being generated with GRO. The fix itself is
> correct for now as long as we do not add any devices that support
> NETIF_F_GSO_GRE_CSUM. When such a device is added it could have the
> potential to mess things up due to the fact that the outer transport header
> points to the outer UDP header and not the GRE header as would be expected.
>
> Fixes: fac8e0f579695 ("tunnels: Don't apply GRO to multiple layers of encapsulation.")
> Signed-off-by: Alexander Duyck <aduyck@mirantis.com>
> ---
>
> v2: Dropped switch statements per suggestion of Tom Herbert.
Applied, thanks Alex.
prev parent reply other threads:[~2016-03-30 20:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 21:55 [net PATCH v2] gro: Allow tunnel stacking in the case of FOU/GUE Alexander Duyck
2016-03-30 20:03 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160330.160320.1141897932138398381.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aduyck@mirantis.com \
--cc=alexander.duyck@gmail.com \
--cc=jesse@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox