From: David Miller <davem@davemloft.net>
To: daniel@iogearbox.net
Cc: eric.dumazet@gmail.com, alexei.starovoitov@gmail.com,
mkubecek@suse.cz, sasha.levin@oracle.com, jslaby@suse.cz,
mst@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH net] tun, bpf: fix suspicious RCU usage in tun_{attach,detach}_filter
Date: Thu, 31 Mar 2016 15:21:49 -0400 (EDT) [thread overview]
Message-ID: <20160331.152149.396188904137423987.davem@davemloft.net> (raw)
In-Reply-To: <56FD1512.70409@iogearbox.net>
From: Daniel Borkmann <daniel@iogearbox.net>
Date: Thu, 31 Mar 2016 14:16:18 +0200
> On 03/31/2016 01:59 PM, Eric Dumazet wrote:
>> On Thu, 2016-03-31 at 13:35 +0200, Daniel Borkmann wrote:
>>
>>> +static inline bool sock_owned_externally(const struct sock *sk)
>>> +{
>>> + return sk->sk_flags & (1UL << SOCK_EXTERNAL_OWNER);
>>> +}
>>> +
>>
>> Have you reinvented sock_flag(sl, SOCK_EXTERNAL_OWNER) ? ;)
>>
>> Anyway, using a flag for this purpose sounds overkill to me.
>
> Right.
>
>> Setting it is a way to 'fool' lockdep anyway...
>
> Yep, correct, we'd be fooling the tun case, so this diff doesn't
> really make it any better there.
I like the currently proposed patch where TUN says that RTNL is what
the synchronizing element is.
Maybe we could make a helper of some sort but since we only have once
case like this is just overkill.
Alexei, do you really mind if I apply Danile's patch?
Thanks.
next prev parent reply other threads:[~2016-03-31 19:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 0:13 [PATCH net] tun, bpf: fix suspicious RCU usage in tun_{attach,detach}_filter Daniel Borkmann
2016-03-31 1:18 ` Alexei Starovoitov
2016-03-31 5:01 ` Michal Kubecek
2016-03-31 5:08 ` Alexei Starovoitov
2016-03-31 5:22 ` Michal Kubecek
2016-03-31 5:43 ` Alexei Starovoitov
2016-03-31 11:35 ` Daniel Borkmann
2016-03-31 11:59 ` Eric Dumazet
2016-03-31 12:16 ` Daniel Borkmann
2016-03-31 19:21 ` David Miller [this message]
2016-03-31 19:24 ` Hannes Frederic Sowa
2016-03-31 19:31 ` Alexei Starovoitov
2016-03-31 19:48 ` David Miller
2016-03-31 19:36 ` David Miller
2016-03-31 19:48 ` Hannes Frederic Sowa
2016-03-31 19:50 ` David Miller
2016-03-31 21:52 ` Daniel Borkmann
2016-03-31 23:31 ` Hannes Frederic Sowa
2016-03-31 12:12 ` Hannes Frederic Sowa
2016-03-31 9:15 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160331.152149.396188904137423987.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexei.starovoitov@gmail.com \
--cc=daniel@iogearbox.net \
--cc=eric.dumazet@gmail.com \
--cc=jslaby@suse.cz \
--cc=mkubecek@suse.cz \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sasha.levin@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).