* [PATCH net] rtnl: fix msg size calculation in if_nlmsg_size()
@ 2016-03-31 16:10 Nicolas Dichtel
2016-03-31 16:13 ` David Ahern
2016-03-31 20:50 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Nicolas Dichtel @ 2016-03-31 16:10 UTC (permalink / raw)
To: davem; +Cc: netdev, Nicolas Dichtel, David Ahern
Size of the attribute IFLA_PHYS_PORT_NAME was missing.
Fixes: db24a9044ee1 ("net: add support for phys_port_name")
CC: David Ahern <dsahern@gmail.com>
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
---
net/core/rtnetlink.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index f2066772d0f3..a75f7e94b445 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -909,6 +909,7 @@ static noinline size_t if_nlmsg_size(const struct net_device *dev,
+ rtnl_link_get_af_size(dev, ext_filter_mask) /* IFLA_AF_SPEC */
+ nla_total_size(MAX_PHYS_ITEM_ID_LEN) /* IFLA_PHYS_PORT_ID */
+ nla_total_size(MAX_PHYS_ITEM_ID_LEN) /* IFLA_PHYS_SWITCH_ID */
+ + nla_total_size(IFNAMSIZ) /* IFLA_PHYS_PORT_NAME */
+ nla_total_size(1); /* IFLA_PROTO_DOWN */
}
--
2.4.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] rtnl: fix msg size calculation in if_nlmsg_size() 2016-03-31 16:10 [PATCH net] rtnl: fix msg size calculation in if_nlmsg_size() Nicolas Dichtel @ 2016-03-31 16:13 ` David Ahern 2016-03-31 20:50 ` David Miller 1 sibling, 0 replies; 3+ messages in thread From: David Ahern @ 2016-03-31 16:13 UTC (permalink / raw) To: Nicolas Dichtel, davem; +Cc: netdev On 3/31/16 10:10 AM, Nicolas Dichtel wrote: > Size of the attribute IFLA_PHYS_PORT_NAME was missing. > > Fixes: db24a9044ee1 ("net: add support for phys_port_name") > CC: David Ahern <dsahern@gmail.com> > Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> > --- > net/core/rtnetlink.c | 1 + > 1 file changed, 1 insertion(+) Acked-by: David Ahern <dsahern@gmail.com> ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] rtnl: fix msg size calculation in if_nlmsg_size() 2016-03-31 16:10 [PATCH net] rtnl: fix msg size calculation in if_nlmsg_size() Nicolas Dichtel 2016-03-31 16:13 ` David Ahern @ 2016-03-31 20:50 ` David Miller 1 sibling, 0 replies; 3+ messages in thread From: David Miller @ 2016-03-31 20:50 UTC (permalink / raw) To: nicolas.dichtel; +Cc: netdev, dsahern From: Nicolas Dichtel <nicolas.dichtel@6wind.com> Date: Thu, 31 Mar 2016 18:10:31 +0200 > Size of the attribute IFLA_PHYS_PORT_NAME was missing. > > Fixes: db24a9044ee1 ("net: add support for phys_port_name") > CC: David Ahern <dsahern@gmail.com> > Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> Applied, and queued up for -stable, thanks Nicolas. Man... this thing is getting really huge and unwieldly. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-31 20:50 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-03-31 16:10 [PATCH net] rtnl: fix msg size calculation in if_nlmsg_size() Nicolas Dichtel 2016-03-31 16:13 ` David Ahern 2016-03-31 20:50 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).