From: David Miller <davem@davemloft.net>
To: roy.qing.li@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] bridge: remove br_dev_set_multicast_list
Date: Fri, 01 Apr 2016 14:43:19 -0400 (EDT) [thread overview]
Message-ID: <20160401.144319.1278231945562755336.davem@davemloft.net> (raw)
In-Reply-To: <1459498570-30664-1-git-send-email-roy.qing.li@gmail.com>
From: roy.qing.li@gmail.com
Date: Fri, 1 Apr 2016 16:16:10 +0800
> From: Li RongQing <roy.qing.li@gmail.com>
>
> remove br_dev_set_multicast_list which does nothing
>
> Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
This will break SIOCADDMULTI et al. on the bridge, see net/core/dev.c
which checks whether this ndo OP is NULL or not.
Please sufficiently grep the source tree on how an ndo operation is
used before making changes like this.
Thanks.
prev parent reply other threads:[~2016-04-01 18:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 8:16 [PATCH] bridge: remove br_dev_set_multicast_list roy.qing.li
2016-04-01 18:43 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160401.144319.1278231945562755336.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=roy.qing.li@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).