netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: bastienphilbert@gmail.com
Cc: stephen@networkplumber.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bridge:Fix incorrect variable assignment on error path in br_sysfs_addbr
Date: Mon, 04 Apr 2016 16:14:18 -0400 (EDT)	[thread overview]
Message-ID: <20160404.161418.1551441547560943567.davem@davemloft.net> (raw)
In-Reply-To: <1459724666-3666-1-git-send-email-bastienphilbert@gmail.com>

From: Bastien Philbert <bastienphilbert@gmail.com>
Date: Sun,  3 Apr 2016 19:04:26 -0400

> This fixes the incorrect variable assignment on error path in
> br_sysfs_addbr for when the call to kobject_create_and_add
> fails to assign the value of -EINVAL to the returned variable of
> err rather then incorrectly return zero making callers think this
> function has succeededed due to the previous assignment being
> assigned zero when assigning it the successful return value of
> the call to sysfs_create_group which is zero.
> 
> Signed-off-by: Bastien Philbert <bastienphilbert@gmail.com>

Applied, but please put a space after the subsystem prefix and the
colon character in your subject lines in the future.

Doesn't that really look odd to you, the way you did it? "net:Fix"?

Doesn't it look more natural, and consistent with what all other
patch submitters do, if it's "net: Fix"?

Thanks.

  reply	other threads:[~2016-04-04 20:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-03 23:04 [PATCH] bridge:Fix incorrect variable assignment on error path in br_sysfs_addbr Bastien Philbert
2016-04-04 20:14 ` David Miller [this message]
2016-04-04 20:16   ` Bastien Philbert
  -- strict thread matches above, loose matches on Subject: below --
2016-03-16 18:31 Nicholas Krause
2016-03-13  2:46 Nicholas Krause

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160404.161418.1551441547560943567.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bastienphilbert@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).