From: David Miller <davem@davemloft.net>
To: willemdebruijn.kernel@gmail.com
Cc: netdev@vger.kernel.org, samanthakumar@google.com,
edumazet@google.com, willemb@google.com
Subject: Re: [PATCH net-next 0/4] udp: support SO_PEEK_OFFSET
Date: Mon, 04 Apr 2016 17:49:47 -0400 (EDT) [thread overview]
Message-ID: <20160404.174947.926111909781290127.davem@davemloft.net> (raw)
In-Reply-To: <1459726193-20863-1-git-send-email-willemdebruijn.kernel@gmail.com>
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Date: Sun, 3 Apr 2016 19:29:49 -0400
> From: Willem de Bruijn <willemb@google.com>
>
> Support peeking at a non-zero offset for UDP sockets. Match the
> existing behavior on Unix datagram sockets.
>
> 1/4 makes the sk_peek_offset functions safe to use outside locks
> 2/4 removes udp headers before enqueue, to simplify offset arithmetic
> 3/4 introduces SO_PEEK_OFFSET support
> 4/4 moves sk->sk_peek_off on read, to match Unix socket semantics.
I don't see how you can separate patches #3 and #4.
Once you hook up the socket operation, the user can successfully use
the feature and therefore must receive the full set of semantics.
You hook up the op in patch #3 but only give the full proper semantics
in #4.
next prev parent reply other threads:[~2016-04-04 21:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-03 23:29 [PATCH net-next 0/4] udp: support SO_PEEK_OFFSET Willem de Bruijn
2016-04-03 23:29 ` [PATCH net-next 1/4] sock: convert sk_peek_offset functions to WRITE_ONCE Willem de Bruijn
2016-04-03 23:29 ` [PATCH net-next 2/4] udp: remove headers from UDP packets before queueing Willem de Bruijn
2016-04-03 23:29 ` [PATCH net-next 3/4] udp: enable MSG_PEEK at non-zero offset Willem de Bruijn
2016-04-03 23:29 ` [PATCH net-next 4/4] udp: move peek offset on read and peek Willem de Bruijn
2016-04-04 21:49 ` David Miller [this message]
2016-04-04 22:23 ` [PATCH net-next 0/4] udp: support SO_PEEK_OFFSET Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160404.174947.926111909781290127.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=samanthakumar@google.com \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).