From: David Miller <davem@davemloft.net>
To: quentin@armitage.org.uk
Cc: kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org,
kaber@trash.net, netdev@vger.kernel.org
Subject: Re: [PATCH v2] net: remove unimplemented RTNH_F_PERVASIVE
Date: Tue, 05 Apr 2016 19:57:59 -0400 (EDT) [thread overview]
Message-ID: <20160405.195759.110758435613250333.davem@davemloft.net> (raw)
In-Reply-To: <1459615888-456-1-git-send-email-quentin@armitage.org.uk>
From: Quentin Armitage <quentin@armitage.org.uk>
Date: Sat, 2 Apr 2016 17:51:28 +0100
> Linux 2.1.68 introduced RTNH_F_PERVASIVE, but it had no implementation
> and couldn't be enabled since the required config parameter wasn't in
> any Kconfig file (see commit d088dde7b196 ("ipv4: obsolete config in
> kernel source (IP_ROUTE_PERVASIVE)")).
>
> This commit removes all remaining references to RTNH_F_PERVASIVE.
> Although this will cause userspace applications that were using the
> flag to fail to build, they will be alerted to the fact that using
> RTNH_F_PERVASIVE was not achieving anything.
>
> Signed-off-by: Quentin Armitage <quentin@armitage.org.uk>
Can't really delete values like this from user visible headers. It
can break the build.
What if some library or tool has a table translating RTNH_F_* values
into strings to display to the user? Those sources will stop building
if I apply your changes.
prev parent reply other threads:[~2016-04-05 23:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-02 8:43 [PATCH] net: remove unimplemented RTNH_F_PERVASIVE Quentin Armitage
2016-04-02 16:04 ` Sergei Shtylyov
2016-04-02 16:51 ` [PATCH v2] " Quentin Armitage
2016-04-05 23:57 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160405.195759.110758435613250333.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=quentin@armitage.org.uk \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).