From: Andrew Lunn <andrew@lunn.ch>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@savoirfairelinux.com,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Jiri Pirko <jiri@resnulli.us>, Scott Feldman <sfeldma@gmail.com>
Subject: Re: [PATCH net-next 1/3] net: dsa: make the STP state function return void
Date: Wed, 6 Apr 2016 01:47:14 +0200 [thread overview]
Message-ID: <20160405234714.GB19409@lunn.ch> (raw)
In-Reply-To: <1459869875-23815-1-git-send-email-vivien.didelot@savoirfairelinux.com>
> -- port_stp_update: bridge layer function invoked when a given switch port STP
> +- port_stp_state: bridge layer function invoked when a given switch port STP
Hi Vivien
port_stp_state_set might be a better name, to make it clear it is
setting the state, not getting the current state, etc. Most of the
other functions are _add, _prepare, _join, _leave, so _set would fit
the pattern.
Changing to a void makes sense.
Andrew
next prev parent reply other threads:[~2016-04-05 23:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 15:24 [PATCH net-next 1/3] net: dsa: make the STP state function return void Vivien Didelot
2016-04-05 15:24 ` [PATCH net-next 2/3] net: dsa: make the FDB add " Vivien Didelot
2016-04-05 23:51 ` Andrew Lunn
2016-04-06 3:14 ` Vivien Didelot
2016-04-06 12:54 ` Andrew Lunn
2016-04-06 14:26 ` Vivien Didelot
2016-04-05 15:24 ` [PATCH net-next 3/3] net: dsa: make the VLAN " Vivien Didelot
2016-04-05 23:47 ` Andrew Lunn [this message]
2016-04-06 3:16 ` [PATCH net-next 1/3] net: dsa: make the STP state " Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160405234714.GB19409@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jiri@resnulli.us \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sfeldma@gmail.com \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).