From: David Miller <davem@davemloft.net>
To: makita.toshiaki@lab.ntt.co.jp
Cc: lucien.xin@gmail.com, nikolay@cumulusnetworks.com,
netdev@vger.kernel.org, bridge@lists.linux-foundation.org
Subject: Re: [PATCHv2 net-next 3/6] bridge: simplify the stp_state_store by calling store_bridge_parm
Date: Wed, 06 Apr 2016 16:10:43 -0400 (EDT) [thread overview]
Message-ID: <20160406.161043.260012491646006960.davem@davemloft.net> (raw)
In-Reply-To: <5703483D.80109@lab.ntt.co.jp>
From: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Date: Tue, 5 Apr 2016 14:08:13 +0900
> On 2016/04/05 12:32, Xin Long wrote:
>> There are some repetitive codes in stp_state_store, we can remove
>> them by calling store_bridge_parm.
>>
>> Signed-off-by: Xin Long <lucien.xin@gmail.com>
>> ---
>> net/bridge/br_sysfs_br.c | 24 +++++++-----------------
>> 1 file changed, 7 insertions(+), 17 deletions(-)
>>
>> diff --git a/net/bridge/br_sysfs_br.c b/net/bridge/br_sysfs_br.c
>> index 137cd3b..9918763 100644
>> --- a/net/bridge/br_sysfs_br.c
>> +++ b/net/bridge/br_sysfs_br.c
>> @@ -128,27 +128,17 @@ static ssize_t stp_state_show(struct device *d,
>> }
>>
>>
>> +static int set_stp_state(struct net_bridge *br, unsigned long val)
>> +{
>
> You forgot to add rtnl lock here?
> The missing lock is restored in patch 4, but at this point bisect could
> break..
Agreed, this has to be fixed.
next prev parent reply other threads:[~2016-04-06 20:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 3:32 [PATCHv2 net-next 0/6] bridge: support sending rntl info when we set attributes through sysfs/ioctl Xin Long
2016-04-05 3:32 ` [PATCHv2 net-next 1/6] bridge: simplify the flush_store by calling store_bridge_parm Xin Long
2016-04-05 3:32 ` [PATCHv2 net-next 2/6] bridge: simplify the forward_delay_store " Xin Long
2016-04-05 3:32 ` [PATCHv2 net-next 3/6] bridge: simplify the stp_state_store " Xin Long
2016-04-05 3:32 ` [PATCHv2 net-next 4/6] bridge: a netlink notification should be sent when those attributes are changed by br_sysfs_br Xin Long
2016-04-05 3:32 ` [PATCHv2 net-next 5/6] bridge: a netlink notification should be sent when those attributes are changed by br_sysfs_if Xin Long
2016-04-05 3:32 ` [PATCHv2 net-next 6/6] bridge: a netlink notification should be sent when those attributes are changed by ioctl Xin Long
2016-04-05 5:08 ` [PATCHv2 net-next 3/6] bridge: simplify the stp_state_store by calling store_bridge_parm Toshiaki Makita
2016-04-06 20:10 ` David Miller [this message]
2016-04-07 3:49 ` Xin Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160406.161043.260012491646006960.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bridge@lists.linux-foundation.org \
--cc=lucien.xin@gmail.com \
--cc=makita.toshiaki@lab.ntt.co.jp \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).